From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NCSQ1-0006Qw-QV for qemu-devel@nongnu.org; Mon, 23 Nov 2009 01:29:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NCSPx-0006QU-SW for qemu-devel@nongnu.org; Mon, 23 Nov 2009 01:29:01 -0500 Received: from [199.232.76.173] (port=39151 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NCSPx-0006QR-LR for qemu-devel@nongnu.org; Mon, 23 Nov 2009 01:28:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41705) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NCSPw-0006rW-TV for qemu-devel@nongnu.org; Mon, 23 Nov 2009 01:28:57 -0500 Date: Mon, 23 Nov 2009 08:28:49 +0200 From: Gleb Natapov Subject: Re: [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test Message-ID: <20091123062849.GA2999@redhat.com> References: <20091122140853.GI3193@redhat.com> <20091122172101.GB9880@redhat.com> <38AF5F086DB24529A1D605A0E2414FD0@FSCPC> <4B09CFDA.80705@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B09CFDA.80705@gmx.net> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Carl-Daniel Hailfinger Cc: kevin@koconnor.net, qemu-devel@nongnu.org, Sebastian Herbszt On Mon, Nov 23, 2009 at 12:57:14AM +0100, Carl-Daniel Hailfinger wrote: > On 22.11.2009 18:39, Sebastian Herbszt wrote: > > Gleb Natapov wrote: > >> On Sun, Nov 22, 2009 at 05:51:41PM +0100, Sebastian Herbszt wrote: > >>> Is the requirement for "Targeted Content Delivery" specified > >>> somewhere with something more > >>> clear than "SMBIOS data is useful in identifying the computer for > >>> targeted delivery of > >>> model-specific software and firmware content" (e.g. changing BIOS > >>> version, release date, etc.)? > >>> > >>> >@@ -130,8 +131,8 @@ smbios_init_type_1(void *start) > >>> > p->header.length = sizeof(struct smbios_type_1); > >>> > p->header.handle = 0x100; > >>> > > >>> >- load_str_field_or_skip(1, manufacturer_str); > >>> >- load_str_field_or_skip(1, product_name_str); > >>> >+ load_str_field_with_default(1, manufacturer_str, "QEMU"); > >>> >+ load_str_field_with_default(1, product_name_str, "QEMU"); > >>> > >>> Use "QEMU Virtual Platform" product name derivated from "VMware > >>> Virtual Platform" ? > >>> Use "QEMU Project" or "QEMU Community" throughout for manufacturer > >>> name? > >> I'll change this to use defines as per Kevin's request, so to keep > >> number of defines to minimum > >> lets make it "QEMU Project" everywhere. > > > > Will you introduce something like CONFIG_SYSVENDOR? Would be useful in > > case some other project > > (Bochs, Xen?) starts to use seabios. > > coreboot already uses SeaBIOS on various x86 hardware platforms. > But does coreboot use SMBIOS tables generated by SeaBIOS? -- Gleb.