From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NCYds-0007su-Gp
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 08:07:44 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NCYdn-0007sL-OJ
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 08:07:44 -0500
Received: from [199.232.76.173] (port=52546 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NCYdn-0007sI-Jz
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 08:07:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:30084)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NCYdm-0004lb-Os
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 08:07:39 -0500
Date: Mon, 23 Nov 2009 11:07:27 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] Re: [RFC v0 00/15] QEMU Monitor Protocol
Message-ID: <20091123110727.0b565d5b@doriath>
In-Reply-To: <4B0960FF.9030409@codemonkey.ws>
References: <1258643623-8636-1-git-send-email-lcapitulino@redhat.com>
	<4B05623E.5080903@redhat.com> <20091119144708.6e00306b@doriath>
	<4B09072E.4090206@redhat.com> <20091122130215.5021843b@doriath>
	<4B0960FF.9030409@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: aliguori@us.ibm.com, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

On Sun, 22 Nov 2009 10:04:15 -0600
Anthony Liguori <anthony@codemonkey.ws> wrote:

> Luiz Capitulino wrote:
> >>> { "execute": "info", "arguments": { "item": "balloon" } }
> >>> {"return": 512}
> >>>
> >>> { "execute": "info", "arguments": { "item": "network" } }
> >>> {"return": [{"devices": [{"name": "user.0", "info": "net=10.0.2.0, restricted=n"}, {"name": "e1000.0", "info": "model=e1000,macaddr=52:54:00:12:34:56"}], "id": 0}]}
> >>>    
> >>>       
> >> The internal "info" is very worrying.  We need to make sure everything 
> >> is returned as an object without the need for additional parsing.
> >>     
> >
> >  That's the complicated part.
> >
> >  Some (several?) Monitor commands would require deeper changes to return
> > 100% of their information in QObject style.
> >
> >  This takes time for me, as I have to dig in subsystems I'm not so
> > familiar with and have to work on the other series too.
> >
> >  So, I've chosen to do the easy conversion now so that the project
> > goes forward. I know this can compromise protocol stability, but I was
> > planning not to declare the protocol stable for 0.12.
> >
> >  This is a discussion we should have.
> >   
> 
> We should not partially convert commands. IOW, if there still is an 
> "info" output, the command is not converted and should not be exposed in 
> the protocol.
> 
> I'm okay with only exposing a few functions in QMP, but I don't want to 
> expose functions whose output is either not well formed or partially 
> converted.

 Ok, I'll cherry-pick the fully converted ones and submit again.