From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NCWmc-00010a-TM
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 06:08:38 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NCWmY-0000rN-04
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 06:08:38 -0500
Received: from [199.232.76.173] (port=42856 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NCWmX-0000rD-S1
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 06:08:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44432)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1NCWmX-00016B-Bk
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 06:08:33 -0500
Date: Mon, 23 Nov 2009 13:08:30 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20091123110830.GE2999@redhat.com>
References: <20091122140853.GI3193@redhat.com>
	<20091122170750.GB13491@morn.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091122170750.GB13491@morn.localdomain>
Subject: [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP
	test
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: qemu-devel@nongnu.org

On Sun, Nov 22, 2009 at 12:07:50PM -0500, Kevin O'Connor wrote:
> On Sun, Nov 22, 2009 at 04:08:53PM +0200, Gleb Natapov wrote:
> > Microsoft SVVP (Server Virtualization Validation Program) expects
> > arbitrary SMBIOS field to have certain values otherwise it fails.
> > We all want to make Microsoft happy don't we? So lets put values MS
> > expects in there.
> [...]
> > -    load_str_field_or_skip(1, manufacturer_str);
> > -    load_str_field_or_skip(1, product_name_str);
> > +    load_str_field_with_default(1, manufacturer_str, "QEMU");
> > +    load_str_field_with_default(1, product_name_str, "QEMU");
> >      load_str_field_or_skip(1, version_str);
> >      load_str_field_or_skip(1, serial_number_str);
> 
> Can the CONFIG_APPNAMExx defines in config.h be used instead of hard
> coding QEMU?  (If desired, the defaults can be changed from bochs to
> qemu.)
Qemu can do it in a local branch. But since Qemu uses SeaBIOS right now and
BOCHS doesn't lets change it.

> 
> > -    memcpy((char *)start, "CPU  " "\0" "" "\0" "", 7);
> > -	((char *)start)[4] = cpu_number + '0';
> > +    memcpy((char *)start, "CPU  \0QEMU\0\0", 12);
> > +    ((char *)start)[4] = cpu_number + '0';
> 
> BTW, snprintf can now be used here.
> 
snprintf in SeaBIOS doesn't have return value. In some situation it is
impossible to use it properly without it.


--
			Gleb.