From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NCYXI-0004ic-Sv
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 08:00:56 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NCYXE-0004gx-PP
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 08:00:56 -0500
Received: from [199.232.76.173] (port=45485 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NCYXE-0004gr-Ic
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 08:00:52 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35512)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1NCYXE-0003aV-1J
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 08:00:52 -0500
Date: Mon, 23 Nov 2009 15:00:43 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] seabios: missing DMI type 4 entry if -cpu
	parameter is used
Message-ID: <20091123130043.GN2999@redhat.com>
References: <A4D600CE1A5042B0B67D112C2FC45A49@FSCPC>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <A4D600CE1A5042B0B67D112C2FC45A49@FSCPC>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: Kevin O'Connor <kevin@koconnor.net>, qemu-devel@nongnu.org

On Sun, Nov 22, 2009 at 06:05:02PM +0100, Sebastian Herbszt wrote:
> v0.11.0-rc0-1677:
> use -cpu pentium and check SMBIOS tables. DMI type 4 entry is missing.
> Works with Bochs bios.
> 
See two problems here. First one in seabios (patch attached). And the
second one in QEMU. Why pentium cpu type lacks apic? Specifying 
-cpu pentium,+apic works with current seabios without the patch.

Signed-off-by: Gleb Natapov <gleb@redhat.com>
diff --git a/src/smp.c b/src/smp.c
index 7100476..00cf64b 100644
--- a/src/smp.c
+++ b/src/smp.c
@@ -75,7 +75,9 @@ smp_probe(void)
     cpuid(1, &eax, &ebx, &ecx, &cpuid_features);
     if (! (cpuid_features & CPUID_APIC)) {
         // No apic - only the main cpu is present.
+        dprintf(1, "No apic - only the main cpu is present.\n");
         CountCPUs= 1;
+        MaxCountCPUs = 1;
         return;
     }
 
--
			Gleb.