From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NCw9b-0000Dh-L6
	for qemu-devel@nongnu.org; Tue, 24 Nov 2009 09:14:03 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NCw9Y-00008m-0z
	for qemu-devel@nongnu.org; Tue, 24 Nov 2009 09:14:03 -0500
Received: from [199.232.76.173] (port=40289 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NCw9X-00008b-Lc
	for qemu-devel@nongnu.org; Tue, 24 Nov 2009 09:13:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44022)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NCw9X-0002yX-9D
	for qemu-devel@nongnu.org; Tue, 24 Nov 2009 09:13:59 -0500
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAOEDw0T028654
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 24 Nov 2009 09:13:58 -0500
Date: Tue, 24 Nov 2009 16:11:22 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091124141122.GM2405@redhat.com>
References: <1259060788-17411-1-git-send-email-kraxel@redhat.com>
	<1259060788-17411-2-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1259060788-17411-2-git-send-email-kraxel@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 2/2] qdev: add command line option to set
	global defaults for properties.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, Nov 24, 2009 at 12:06:28PM +0100, Gerd Hoffmann wrote:
> This patch adds infrastructure and command line option for setting
> global defaults for device properties, i.e. you can for example use
> 
>   -global virtio-blk-pci.vectors=0
> 
> to turn off msi by default for all virtio block devices.  The config
> file syntax is:
> 
> [global]
>   driver = "virtio-blk-pci"
>   property = "vectors"
>   value = "0"

Where's this documented?

> This can also be used to set properties for devices which are not
> created via -device but implicitly via machine init, i.e.
> 
>   -global isa-fdc,driveA=<name>
> 

...

> diff --git a/qemu-options.hx b/qemu-options.hx
> index b65fd74..420b7d8 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -109,6 +109,9 @@ DEF("set", HAS_ARG, QEMU_OPTION_set,
>      "-set group.id.arg=value\n"
>      "                set <arg> parameter for item <id> of type <group>\n"
>      "                i.e. -set drive.$id.file=/path/to/image\n")
> +DEF("global", HAS_ARG, QEMU_OPTION_global,
> +    "-global driver.property=value\n"
> +    "                set a global default for a driver property\n")
>  STEXI
>  @item -drive @var{option}[,@var{option}[,@var{option}[,...]]]

Let's add a hint on how to get the list of drivers and properties?
How would one figure out the command lines you give in
the examples above?


-- 
MST