From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Carsten Otte <cotte@de.ibm.com>, Alexander Graf <agraf@suse.de>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 06/13] Add support for S390x system emulation
Date: Wed, 25 Nov 2009 11:46:14 +0000 [thread overview]
Message-ID: <200911251146.14502.paul@codesourcery.com> (raw)
In-Reply-To: <1259083781-14642-7-git-send-email-agraf@suse.de>
> --- a/target-s390x/cpu.h
> +++ b/target-s390x/cpu.h
> @@ -30,8 +30,7 @@
>
> #include "softfloat.h"
>
> -#define NB_MMU_MODES 2 // guess
> -#define MMU_USER_IDX 0 // guess
> +#define NB_MMU_MODES 2
The fact that you're modifying a file you added earlier in the same patch
series gives me very little confidence...
Paul
next prev parent reply other threads:[~2009-11-25 11:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 17:29 [Qemu-devel] [PATCH 00/13] S390x KVM support v4 Alexander Graf
2009-11-24 17:29 ` [Qemu-devel] [PATCH 01/13] S/390 CPU fake emulation Alexander Graf
2009-11-24 17:29 ` [Qemu-devel] [PATCH 02/13] S/390 host/target build system support Alexander Graf
2009-11-24 17:29 ` [Qemu-devel] [PATCH 03/13] S/390 fake TCG implementation Alexander Graf
2009-11-24 17:29 ` [Qemu-devel] [PATCH 04/13] Add KVM support for S390x Alexander Graf
2009-11-24 17:29 ` [Qemu-devel] [PATCH 05/13] Allocate physical memory in low virtual address space Alexander Graf
2009-11-24 17:29 ` [Qemu-devel] [PATCH 06/13] Add support for S390x system emulation Alexander Graf
2009-11-25 11:46 ` Paul Brook [this message]
2009-11-25 11:47 ` Alexander Graf
2009-11-24 17:29 ` [Qemu-devel] [PATCH 07/13] Add S390x virtio machine bus Alexander Graf
2009-11-24 17:29 ` [Qemu-devel] [PATCH 08/13] Add S390x virtio machine description Alexander Graf
2009-11-24 17:29 ` [Qemu-devel] [PATCH 09/13] S390 GDB stub Alexander Graf
2009-11-24 17:29 ` [Qemu-devel] [PATCH 10/13] Implement early printk in virtio-console Alexander Graf
2009-11-24 18:55 ` Anthony Liguori
2009-11-24 18:56 ` Alexander Graf
2009-11-24 19:25 ` Anthony Liguori
2009-11-24 19:27 ` Alexander Graf
2009-11-24 19:30 ` Anthony Liguori
2009-11-24 19:32 ` Alexander Graf
2009-11-24 19:48 ` Anthony Liguori
2009-11-24 19:58 ` Alexander Graf
2009-11-25 10:00 ` Carsten Otte
2009-11-25 13:14 ` Arnd Bergmann
2009-11-25 13:47 ` Carsten Otte
2009-11-25 9:03 ` Carsten Otte
2009-11-24 17:29 ` [Qemu-devel] [PATCH 11/13] Set default console to virtio on S390x Alexander Graf
2009-11-24 17:29 ` [Qemu-devel] [PATCH 12/13] Add zipl bootloader interpreter Alexander Graf
2009-11-24 18:53 ` Anthony Liguori
2009-11-24 18:56 ` Alexander Graf
2009-11-24 19:26 ` Anthony Liguori
2009-11-24 19:29 ` Alexander Graf
2009-11-24 20:39 ` Mark Williamson
2009-11-24 21:10 ` Anthony Liguori
2009-11-25 8:35 ` Hannes Reinecke
2009-11-25 8:38 ` Alexander Graf
2009-11-25 10:09 ` Carsten Otte
2009-11-25 10:02 ` Carsten Otte
2009-11-25 9:58 ` Carsten Otte
2009-11-25 8:59 ` Carsten Otte
2009-11-24 17:29 ` [Qemu-devel] [PATCH 13/13] Add S390 maintainer information Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911251146.14502.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=cotte@de.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).