qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/2] qdev: add command line option to set global defaults for properties.
Date: Wed, 25 Nov 2009 15:18:04 +0200	[thread overview]
Message-ID: <20091125131804.GB9333@redhat.com> (raw)
In-Reply-To: <4B0D2936.9000707@redhat.com>

On Wed, Nov 25, 2009 at 01:55:18PM +0100, Gerd Hoffmann wrote:
> On 11/24/09 15:11, Michael S. Tsirkin wrote:
>> On Tue, Nov 24, 2009 at 12:06:28PM +0100, Gerd Hoffmann wrote:
>>> This patch adds infrastructure and command line option for setting
>>> global defaults for device properties, i.e. you can for example use
>>>
>>>    -global virtio-blk-pci.vectors=0
>>>
>>> to turn off msi by default for all virtio block devices.  The config
>>> file syntax is:
>>>
>>> [global]
>>>    driver = "virtio-blk-pci"
>>>    property = "vectors"
>>>    value = "0"
>>
>> Where's this documented?
>
> config file syntax is git-style, the details are not (yet) documented.
>
> Easiest way to get one if you want to play with it is
>   "qemu <all-your-vm-options-here> -writeconfig <filename>".
>
> Note that not all command line options are covered.
>
> I've attached a sample to this mail.  Needs a few patches sent to the  
> list yesterday and today to actually work though.
>
>> How would one figure out the command lines you give in
>> the examples above?
>
> "info qtree" in monitor prints the device names and properties for all  
> devices used by the virtual machine.
>
> "info qdm" and '-device ?' list all devices known to qemu.

So maybe add "use -device ? to get list of all devices"
to help text?

[mst@tuck qemu]$ ~/qemu-git/bin/qemu-system-x86_64 -device ?
/home/mst/qemu-git/bin/qemu-system-x86_64: invalid option -- '-device'
[mst@tuck qemu]$ ~/qemu-git/bin/qemu-system-x86_64 --device ?
/home/mst/qemu-git/bin/qemu-system-x86_64: invalid option -- '-device'

>  The device  
> properties are not listed there though (one of the items on my todo 
> list).

Yes, and in fact each option should supply a help text
explaining what it is. This was not done this way upfront
and each day makes it harder to document as new options
are added without documentation.


> cheers,
>   Gerd

  reply	other threads:[~2009-11-25 13:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-24 11:06 [Qemu-devel] [PATCH 1/2] qdev: make compat stuff more generic Gerd Hoffmann
2009-11-24 11:06 ` [Qemu-devel] [PATCH 2/2] qdev: add command line option to set global defaults for properties Gerd Hoffmann
2009-11-24 14:11   ` [Qemu-devel] " Michael S. Tsirkin
2009-11-25 12:55     ` Gerd Hoffmann
2009-11-25 13:18       ` Michael S. Tsirkin [this message]
2009-11-25 14:03         ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091125131804.GB9333@redhat.com \
    --to=mst@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).