From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NDdes-0002Rz-ED for qemu-devel@nongnu.org; Thu, 26 Nov 2009 07:41:14 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NDden-0002NE-P5 for qemu-devel@nongnu.org; Thu, 26 Nov 2009 07:41:14 -0500 Received: from [199.232.76.173] (port=49002 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NDden-0002Mu-FP for qemu-devel@nongnu.org; Thu, 26 Nov 2009 07:41:09 -0500 Received: from mx20.gnu.org ([199.232.41.8]:13423) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NDden-0000P7-77 for qemu-devel@nongnu.org; Thu, 26 Nov 2009 07:41:09 -0500 Received: from mail.codesourcery.com ([38.113.113.100]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NDdem-0004c0-0v for qemu-devel@nongnu.org; Thu, 26 Nov 2009 07:41:08 -0500 From: Paul Brook Subject: Re: [Qemu-devel] Re: [PATCH 0/4] pci: interrupt status/interrupt disable support Date: Thu, 26 Nov 2009 12:41:03 +0000 References: <20091125165834.GA24783@redhat.com> <20091126032146.GH25483%yamahata@valinux.co.jp> <20091126094811.GB26861@redhat.com> In-Reply-To: <20091126094811.GB26861@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200911261241.04148.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Isaku Yamahata , "Michael S. Tsirkin" > No, this would slow us down because these are per-pin. > We need a sum of interrupts so that config space > can be updated by a single command. > Interrupts are a fastpath, extra loops there should be avoided. It's really not that much of a fast path. Unless you're doing something particularly obscure then even under heavy load you're unlikely to exceed a few kHz. Compared to the average PIC implementation, and the overhead of the actual CPU interrupt, I find it hard to believe that looping over precisely 4 entries has any real performance hit. Paul