From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NF8n6-0006Xz-Ix
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 11:07:56 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NF8n1-0006Wy-Gd
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 11:07:55 -0500
Received: from [199.232.76.173] (port=42467 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NF8n0-0006Wm-QA
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 11:07:51 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45325)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NF8mz-0002kh-FS
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 11:07:50 -0500
Date: Mon, 30 Nov 2009 18:04:58 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091130160458.GI30871@redhat.com>
References: <20091008155256.GA13660@redhat.com>
	<20091130141722.GB25613@redhat.com>
	<4B13EC17.1040102@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B13EC17.1040102@linux.vnet.ibm.com>
Subject: [Qemu-devel] Re: [PATCHv2-repost] pcbios: enable io/memory
	unconditionally
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@linux.vnet.ibm.com>
Cc: Avi Kivity <avi@redhat.com>, kvm-devel <kvm@vger.kernel.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Mon, Nov 30, 2009 at 10:00:23AM -0600, Anthony Liguori wrote:
> Michael S. Tsirkin wrote:
>> On Thu, Oct 08, 2009 at 05:52:56PM +0200, Michael S. Tsirkin wrote:
>> VGA adapters need to claim memory and i/o
>> transactions even if they do not have any
>> i/o or memory bars. E.g. PCI spec, page 297,
>> gives an example of such a device:
>>
>>         Programming interface 0000 0000b
>>         VGA-compatible controller. Memory
>>         addresses 0A 0000h through 0B
>>         FFFFh. I/O addresses 3B0h to 3BBh
>>         and 3C0h to 3DFh and all aliases of
>>         these addresses.
>>
>> While we could check for these devices and special-case them, it is
>> easier to fix this by enabling i/o and memory space unconditionally:
>> devices that do not support it will just ignore this setting.
>>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>   
>
> This is for stable?

This is for qemu-kvm as the description says.

>> ---
>>
>> This patch is needed for qemu-kvm as that is still using pcbios.
>>   
>
> Why hasn't qemu-kvm switched to seabios?

IMO it's better to fix bug then switch than the reverse.
This way you have a good base to compare against.


> -- 
> Regards,
>
> Anthony Liguori