From: Aurelien Jarno <aurelien@aurel32.net>
To: Alexander Graf <agraf@suse.de>
Cc: Carsten Otte <cotte@de.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 05/11] Allocate physical memory in low virtual address space
Date: Mon, 30 Nov 2009 19:18:43 +0100 [thread overview]
Message-ID: <20091130181843.GA26620@volta.aurel32.net> (raw)
In-Reply-To: <1259241800-2810-6-git-send-email-agraf@suse.de>
On Thu, Nov 26, 2009 at 02:23:14PM +0100, Alexander Graf wrote:
> KVM on S390x requires the virtual address space of the guest's RAM to be
> within the first 256GB.
>
While I have no problem with this patch, I am curious to know the reason
of this. No need to change anything in the patch.
> The general direction I'd like to see KVM on S390 move is that this requirement
> is losened, but for now that's what we're stuck with.
>
> So let's just hack up qemu_ram_alloc until KVM behaves nicely :-).
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> exec.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 076d26b..59150d0 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2411,7 +2411,13 @@ ram_addr_t qemu_ram_alloc(ram_addr_t size)
> size = TARGET_PAGE_ALIGN(size);
> new_block = qemu_malloc(sizeof(*new_block));
>
> +#if defined(TARGET_S390) && defined(CONFIG_KVM)
> + /* XXX S390 KVM requires the topmost vma of the RAM to be < 256GB */
> + new_block->host = mmap(0x1000000, size, PROT_EXEC|PROT_READ|PROT_WRITE,
> + MAP_SHARED | MAP_ANONYMOUS, -1, 0);
> +#else
> new_block->host = qemu_vmalloc(size);
> +#endif
> #ifdef MADV_MERGEABLE
> madvise(new_block->host, size, MADV_MERGEABLE);
> #endif
> --
> 1.6.0.2
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2009-11-30 19:28 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 13:23 [Qemu-devel] [PATCH 00/11] S390x KVM support v4 Alexander Graf
2009-11-26 13:23 ` [Qemu-devel] [PATCH 01/11] S/390 CPU fake emulation Alexander Graf
2009-11-30 18:18 ` Aurelien Jarno
2009-11-30 22:30 ` Alexander Graf
2009-12-01 9:46 ` Carsten Otte
2009-12-01 10:11 ` Alexander Graf
2009-12-01 18:45 ` Blue Swirl
2009-12-02 7:55 ` Carsten Otte
2009-12-02 14:41 ` Paul Brook
2009-12-02 8:17 ` Aurelien Jarno
2009-12-02 8:30 ` Alexander Graf
2009-11-26 13:23 ` [Qemu-devel] [PATCH 02/11] S/390 host/target build system support Alexander Graf
2009-11-26 13:23 ` [Qemu-devel] [PATCH 03/11] S/390 fake TCG implementation Alexander Graf
2009-11-30 18:18 ` Aurelien Jarno
2009-11-30 22:27 ` Alexander Graf
2009-12-02 8:16 ` Aurelien Jarno
2009-12-02 8:29 ` Alexander Graf
2009-12-02 8:41 ` Aurelien Jarno
2009-12-02 8:44 ` Alexander Graf
2009-11-26 13:23 ` [Qemu-devel] [PATCH 04/11] Add KVM support for S390x Alexander Graf
2009-11-30 18:18 ` Aurelien Jarno
2009-11-30 22:25 ` Alexander Graf
2009-12-02 8:12 ` Aurelien Jarno
2009-12-02 8:28 ` Alexander Graf
2009-12-02 8:42 ` malc
2009-12-02 8:47 ` Alexander Graf
2009-12-02 8:59 ` malc
2009-12-02 9:36 ` Markus Armbruster
2009-12-02 9:48 ` malc
2009-11-26 13:23 ` [Qemu-devel] [PATCH 05/11] Allocate physical memory in low virtual address space Alexander Graf
2009-11-30 18:18 ` Aurelien Jarno [this message]
2009-11-30 22:21 ` Alexander Graf
2009-12-01 9:12 ` Carsten Otte
2009-11-26 13:23 ` [Qemu-devel] [PATCH 06/11] Add support for S390x system emulation Alexander Graf
2009-11-30 18:18 ` Aurelien Jarno
2009-11-30 22:19 ` Alexander Graf
2009-12-02 8:09 ` Aurelien Jarno
2009-12-02 8:27 ` Alexander Graf
2009-12-02 8:37 ` Aurelien Jarno
2009-12-02 8:41 ` Alexander Graf
2009-12-01 9:17 ` Carsten Otte
2009-11-26 13:23 ` [Qemu-devel] [PATCH 07/11] Add S390x virtio machine bus Alexander Graf
2009-11-26 13:23 ` [Qemu-devel] [PATCH 08/11] Add S390x virtio machine description Alexander Graf
2009-11-30 18:18 ` Aurelien Jarno
2009-11-26 13:23 ` [Qemu-devel] [PATCH 09/11] S390 GDB stub Alexander Graf
2009-11-26 13:23 ` [Qemu-devel] [PATCH 10/11] Set default console to virtio on S390x Alexander Graf
2009-11-26 13:23 ` [Qemu-devel] [PATCH 11/11] Add S390 maintainer information Alexander Graf
2009-11-30 18:18 ` [Qemu-devel] [PATCH 00/11] S390x KVM support v4 Aurelien Jarno
-- strict thread matches above, loose matches on Subject: below --
2009-12-05 11:44 [Qemu-devel] [PATCH 00/11] S390x KVM support v5 Alexander Graf
2009-12-05 11:44 ` [Qemu-devel] [PATCH 05/11] Allocate physical memory in low virtual address space Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091130181843.GA26620@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=agraf@suse.de \
--cc=cotte@de.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).