From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFBYg-0003ju-Cw for qemu-devel@nongnu.org; Mon, 30 Nov 2009 14:05:14 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFBYb-0003e2-Ma for qemu-devel@nongnu.org; Mon, 30 Nov 2009 14:05:13 -0500 Received: from [199.232.76.173] (port=36944 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFBYb-0003dt-FI for qemu-devel@nongnu.org; Mon, 30 Nov 2009 14:05:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1277) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFBYZ-0007BW-OZ for qemu-devel@nongnu.org; Mon, 30 Nov 2009 14:05:08 -0500 Date: Mon, 30 Nov 2009 21:02:26 +0200 From: "Michael S. Tsirkin" Message-ID: <20091130190226.GB457@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [Qemu-devel] [PATCHv5-repost 1/2] qemu: make cirrus init value pci spec compliant List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Anthony Liguori , "qemu-devel@nongnu.org" , kvm-devel , Juan Quintela PCI memory should be disabled at reset, otherwise we might claim transactions at address 0. I/O should also be disabled, although for cirrus it is harmless to enable it as we do not have I/O bar. Note: bios fix needed for this patch to work was already applied: previously bios incorrently assumed that it does not need to enable i/o unless device has i/o bar. Signed-off-by: Michael S. Tsirkin Acked-by: Juan Quintela --- hw/cirrus_vga.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index d76e5bb..e16026f 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -3231,7 +3231,6 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev) /* setup PCI */ pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_CIRRUS); pci_config_set_device_id(pci_conf, device_id); - pci_conf[0x04] = PCI_COMMAND_IOACCESS | PCI_COMMAND_MEMACCESS; pci_config_set_class(pci_conf, PCI_CLASS_DISPLAY_VGA); pci_conf[PCI_HEADER_TYPE] = PCI_HEADER_TYPE_NORMAL; -- 1.6.5.2.143.g8cc62