From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] raw: Use the right host device driver for open/create
Date: Mon, 30 Nov 2009 21:51:20 +0100 [thread overview]
Message-ID: <20091130205120.GA6053@lst.de> (raw)
In-Reply-To: <1259596471-14576-1-git-send-email-kwolf@redhat.com>
On Mon, Nov 30, 2009 at 04:54:31PM +0100, Kevin Wolf wrote:
> Users don't expect that they need to specify host_device/cdrom/floppy when
> "creating" an image on a block device or converting with an device as target.
> Currently creating as raw leads to 'Error while formatting' whereas using as
> raw just works.
>
> With this patch raw is accepted for both files and host devices. For devices
> the block driver is transparently changed to host_*.
I agree that we should allow raw to also cover host devices, but I don't
like the implementation very much. Beeing used to specify the format is
pretty much the only reason to have the name in the block driver anyway,
and looking it up in one is a bit of a layering violation.
I'd suggest to either allow multiple formats with the same name and
looping over them or some sort of alias property in the block driver to
also match the alias instead.
next prev parent reply other threads:[~2009-11-30 20:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 15:54 [Qemu-devel] [PATCH] raw: Use the right host device driver for open/create Kevin Wolf
2009-11-30 20:51 ` Christoph Hellwig [this message]
2009-12-03 17:43 ` Anthony Liguori
2009-12-04 8:39 ` Kevin Wolf
2009-12-11 9:04 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091130205120.GA6053@lst.de \
--to=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).