From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFpN2-0004aB-4h for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:35:52 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFpMw-0004W9-Rt for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:35:51 -0500 Received: from [199.232.76.173] (port=49174 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFpMw-0004Vo-Iz for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:35:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:31873) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFpMw-0003Fn-4q for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:35:46 -0500 Date: Wed, 2 Dec 2009 15:33:06 +0200 From: "Michael S. Tsirkin" Message-ID: <20091202133306.GA18193@redhat.com> References: <20091130190226.GB457@redhat.com> <4B166311.7040300@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B166311.7040300@redhat.com> Subject: [Qemu-devel] Re: [PATCHv5-repost 1/2] qemu: make cirrus init value pci spec compliant List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Anthony Liguori , "qemu-devel@nongnu.org" , kvm-devel , Juan Quintela On Wed, Dec 02, 2009 at 02:52:33PM +0200, Avi Kivity wrote: > On 11/30/2009 09:02 PM, Michael S. Tsirkin wrote: >> PCI memory should be disabled at reset, otherwise >> we might claim transactions at address 0. >> I/O should also be disabled, although for cirrus >> it is harmless to enable it as we do not >> have I/O bar. >> >> Note: bios fix needed for this patch to work >> was already applied: >> previously bios incorrently assumed that it does not >> need to enable i/o unless device has i/o bar. >> > > Is this for qemu-kvm.git or qemu.git? > > -- > error compiling committee.c: too many arguments to function This for qemu.git -- MST