From: Marcelo Tosatti <mtosatti@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: agraf@suse.de, aliguori@us.ibm.com, qemu-devel@nongnu.org,
avi@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 04/11] qemu_flush_work for remote vcpu execution
Date: Wed, 2 Dec 2009 11:54:45 -0200 [thread overview]
Message-ID: <20091202135445.GA526@amt.cnet> (raw)
In-Reply-To: <20091202134119.GK22678@mothafucka.localdomain>
On Wed, Dec 02, 2009 at 11:41:19AM -0200, Glauber Costa wrote:
> > KVM vcpu threads should block SIGUSR1, set the in-kernel signal mask
> > with KVM_SET_SIGNAL_MASK ioctl, and eat the signal in
> > qemu_wait_io_event (qemu_flush_work should run after eating
> > the signal). Similarly to qemu-kvm's kvm_main_loop_wait.
> >
> > Otherwise a vcpu thread can lose a signal (say handle SIGUSR1 when not
> > holding qemu_global_mutex before kernel entry).
> >
> > I think this the source of the problems patch 8 attempts to fix.
>
> I remember you had patches for both theses fixes.
Only qemu_wait_io_event split.
> Can you resend them, ontop of this series?
There is not much sense to split qemu_wait_io_event after what your
patch set does (it should be split before).
next prev parent reply other threads:[~2009-12-02 13:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 12:51 [Qemu-devel] [PATCH v2 0/11] Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 01/11] Don't mess with halted state Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 02/11] store thread-specific env information Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 03/11] update halted state on mp_state sync Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 04/11] qemu_flush_work for remote vcpu execution Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 05/11] tell kernel about all registers instead of just mp_state Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 06/11] flush state in migration post_load Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 07/11] Don't call kvm cpu reset on initialization Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 08/11] use cpu_kick instead of direct signalling Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 09/11] Use per-cpu reset handlers Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 10/11] Use __thread where available Glauber Costa
2009-12-01 12:51 ` [Qemu-devel] [PATCH v2 11/11] remove smp restriction from kvm Glauber Costa
2009-12-02 10:48 ` [Qemu-devel] [PATCH v2 05/11] tell kernel about all registers instead of just mp_state Gleb Natapov
2009-12-02 11:22 ` Glauber Costa
2009-12-02 12:10 ` [Qemu-devel] " Jan Kiszka
2009-12-02 12:26 ` Gleb Natapov
2009-12-02 12:35 ` Jan Kiszka
2009-12-02 13:27 ` [Qemu-devel] [PATCH v2 04/11] qemu_flush_work for remote vcpu execution Marcelo Tosatti
2009-12-02 13:41 ` Glauber Costa
2009-12-02 13:54 ` Marcelo Tosatti [this message]
2009-12-02 14:01 ` Glauber Costa
2009-12-02 10:59 ` [Qemu-devel] [PATCH v2 0/11] Gleb Natapov
2009-12-02 12:00 ` Glauber Costa
2009-12-02 12:04 ` [Qemu-devel] " Jan Kiszka
2009-12-02 12:22 ` Gleb Natapov
2009-12-02 12:25 ` Jan Kiszka
2009-12-02 12:30 ` Gleb Natapov
2009-12-02 12:33 ` Jan Kiszka
2009-12-02 12:49 ` Gleb Natapov
2009-12-03 7:33 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202135445.GA526@amt.cnet \
--to=mtosatti@redhat.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).