From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NFpg5-0005G5-4w
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:55:33 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NFpg0-0005Cb-DP
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:55:32 -0500
Received: from [199.232.76.173] (port=55323 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NFpg0-0005CW-8j
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:55:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:27701)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mtosatti@redhat.com>) id 1NFpfz-0004qB-Up
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 08:55:28 -0500
Date: Wed, 2 Dec 2009 11:54:45 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 04/11] qemu_flush_work for remote vcpu
	execution
Message-ID: <20091202135445.GA526@amt.cnet>
References: <1259671897-22232-1-git-send-email-glommer@redhat.com>
	<1259671897-22232-2-git-send-email-glommer@redhat.com>
	<1259671897-22232-3-git-send-email-glommer@redhat.com>
	<1259671897-22232-4-git-send-email-glommer@redhat.com>
	<1259671897-22232-5-git-send-email-glommer@redhat.com>
	<20091202132753.GA29490@amt.cnet>
	<20091202134119.GK22678@mothafucka.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091202134119.GK22678@mothafucka.localdomain>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: agraf@suse.de, aliguori@us.ibm.com, qemu-devel@nongnu.org, avi@redhat.com

On Wed, Dec 02, 2009 at 11:41:19AM -0200, Glauber Costa wrote:
> > KVM vcpu threads should block SIGUSR1, set the in-kernel signal mask 
> > with KVM_SET_SIGNAL_MASK ioctl, and eat the signal in
> > qemu_wait_io_event (qemu_flush_work should run after eating
> > the signal). Similarly to qemu-kvm's kvm_main_loop_wait.
> > 
> > Otherwise a vcpu thread can lose a signal (say handle SIGUSR1 when not
> > holding qemu_global_mutex before kernel entry).
> > 
> > I think this the source of the problems patch 8 attempts to fix.
> 
> I remember you had patches for both theses fixes.

Only qemu_wait_io_event split.

> Can you resend them, ontop of this series?

There is not much sense to split qemu_wait_io_event after what your
patch set does (it should be split before).