From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NFtxb-0007qU-BW
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 13:29:55 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NFtxW-0007i9-4L
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 13:29:54 -0500
Received: from [199.232.76.173] (port=55282 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NFtxV-0007hs-Rd
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 13:29:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43080)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NFtxV-0005rp-EU
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 13:29:49 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB2ITmSt020629
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 2 Dec 2009 13:29:48 -0500
Date: Wed, 2 Dec 2009 20:27:07 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091202182707.GC3956@redhat.com>
References: <cover.1259754426.git.quintela@redhat.com>
	<67f3d61df137cfd59fbf5da6b0b999cdf8d28758.1259754427.git.quintela@redhat.com>
	<20091202144333.GB18519@redhat.com> <m37ht5dyng.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m37ht5dyng.fsf@neno.neno>
Subject: [Qemu-devel] Re: [PATCH 15/41] virtio: remove save/load_queue for
	virtio
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, Dec 02, 2009 at 07:22:11PM +0100, Juan Quintela wrote:
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > On Wed, Dec 02, 2009 at 01:04:13PM +0100, Juan Quintela wrote:
> >> diff --git a/hw/virtio.c b/hw/virtio.c
> >> index c136005..b565bf9 100644
> >> --- a/hw/virtio.c
> >> +++ b/hw/virtio.c
> >> @@ -643,8 +643,10 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f)
> >>          qemu_put_be32(f, vdev->vq[i].vring.num);
> >>          qemu_put_be64(f, vdev->vq[i].pa);
> >>          qemu_put_be16s(f, &vdev->vq[i].last_avail_idx);
> >> -        if (vdev->binding->save_queue)
> >> -            vdev->binding->save_queue(vdev->binding_opaque, i, f);
> >> +        if (vdev->type == VIRTIO_PCI &&
> >> +            virtio_pci_msix_present(vdev->binding_opaque)) {
> >> +            qemu_put_be16s(f, &vdev->vq[i].vector);
> >> +        }
> >>      }
> >>  }
> >> 
> >
> > I think this will break build on systems without PCI
> > because virtio_pci.c is not linked in there.
> > Correct?
> 
> It compiles for syborg (it has pci).  There are no other users.
> 
> > Making generic virtio.c depend on virtio_pci.c looks
> > wrong in any case. We have bindings to
> > resolve exactly this dependency problem.
> 
> There is no way that you throw "this" blob to vmstate and it will know
> what to do there.  if it is needed, we can create an empty
> virtio_pci_msix_present() function for !CONFIG_PCI.
> 
> Later, Juan.

That's not the idea. virtio knows nothing about msix etc.  This belongs
in the binding. If you want to know the number of vectors, please put
something like ->get_nvectors in the binding and call that to figure out
whether virtio has multivector.

-- 
MST