From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFuTk-0005Wr-Gc for qemu-devel@nongnu.org; Wed, 02 Dec 2009 14:03:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFuTf-0005QA-Nv for qemu-devel@nongnu.org; Wed, 02 Dec 2009 14:03:07 -0500 Received: from [199.232.76.173] (port=52380 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFuTf-0005Pv-JK for qemu-devel@nongnu.org; Wed, 02 Dec 2009 14:03:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39220) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFuTf-0000Ja-2k for qemu-devel@nongnu.org; Wed, 02 Dec 2009 14:03:03 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB2J32ZD001907 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 2 Dec 2009 14:03:02 -0500 Date: Wed, 2 Dec 2009 21:00:21 +0200 From: "Michael S. Tsirkin" Message-ID: <20091202190021.GG3984@redhat.com> References: <1971390dc6d0ae9014e796f8ee444dee4a90815a.1259754427.git.quintela@redhat.com> <20091202173823.GA3638@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [Qemu-devel] Re: [PATCH 38/41] virtio-blk: use QLIST for the list of requests List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On Wed, Dec 02, 2009 at 07:56:58PM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Dec 02, 2009 at 01:04:36PM +0100, Juan Quintela wrote: > >> viltio_blak_dma_restart_bh() was unsafe, it used req->next after having > >> (possible) put req in another list > >> > >> Signed-off-by: Juan Quintela > > > > Sounds good, but why is this part of vmstate patchset? > > Rest of the patches depend on it. I tried to only do the cleanups needed > for vmstate. I really forced me to not doing more cleanups. > > Later, Juan. But this is bugfix, not cleanup, right? We want bugfixes ASAP, let not mix it with cleanups etc. You can just post 2 series, and note that second one depends on 1'st one. -- MST