From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NGCbk-0006EW-6H for qemu-devel@nongnu.org; Thu, 03 Dec 2009 09:24:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NGCbd-0006Ca-Pp for qemu-devel@nongnu.org; Thu, 03 Dec 2009 09:24:34 -0500 Received: from [199.232.76.173] (port=39548 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NGCbb-0006CC-OA for qemu-devel@nongnu.org; Thu, 03 Dec 2009 09:24:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24346) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NGCbb-0002dt-Hu for qemu-devel@nongnu.org; Thu, 03 Dec 2009 09:24:27 -0500 Date: Thu, 3 Dec 2009 12:23:45 -0200 From: Luiz Capitulino Subject: Re: [Qemu-devel] Re: Staging update (0.12 pending freeze) Message-ID: <20091203122345.346adc3f@doriath> In-Reply-To: <4B16C0B3.3090501@codemonkey.ws> References: <4B1699D3.8010908@codemonkey.ws> <4B16BE74.6030006@siemens.com> <4B16C0B3.3090501@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Jan Kiszka , kraxel@redhat.com, "qemu-devel@nongnu.org" , ehabkost@redhat.com, markmc@redhat.com On Wed, 02 Dec 2009 13:32:03 -0600 Anthony Liguori wrote: > > Both freshly rebased against staging (which doesn't build btw). > > =20 >=20 > Nope, and it won't for a while. Instead of fixing everything, I'm just=20 > focusing on small groups of patches at a time. Right, but people rebasing against it need to build it to be able to fix conflicts and test things. So, here is a list of problems I had to fix/workaround to have staging fully building on x86_64. I'm CC'ing Mark, Gerd and Eduardo because I believe they can help fixing, but I'm unsure on what caused the problems (merge conflicts?). - net: net/dump.c: In function =E2=80=98net_dump_init=E2=80=99: net/dump.c:119: error: =E2=80=98s=E2=80=99 may be used uninitialized in thi= s function - scsi-disk: /home/lcapitulino/src/aliguori-queue/hw/scsi-disk.c: In function =E2=80=98s= csi_handle_write_error=E2=80=99: home/lcapitulino/src/aliguori-queue/hw/scsi-disk.c:176: error: =E2=80=98SCS= IDiskReq=E2=80=99 has no member named =E2=80=98dev=E2=80=99 cc1: warnings being treated as errors /home/lcapitulino/src/aliguori-queue/hw/scsi-disk.c:174: error: unused vari= able =E2=80=98s=E2=80=99 - monitor: /home/lcapitulino/src/aliguori-queue/monitor.c: In function =E2=80=98eject_= device=E2=80=99: /home/lcapitulino/src/aliguori-queue/monitor.c:760: error: invalid storage = class for function =E2=80=98do_eject=E2=80=99 The last problem is a missing '}' in the second if.