From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NGUTz-0003dg-Ox
	for qemu-devel@nongnu.org; Fri, 04 Dec 2009 04:29:47 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NGUTx-0003cA-Sn
	for qemu-devel@nongnu.org; Fri, 04 Dec 2009 04:29:47 -0500
Received: from [199.232.76.173] (port=48804 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NGUTx-0003by-Q1
	for qemu-devel@nongnu.org; Fri, 04 Dec 2009 04:29:45 -0500
Received: from afflict.kos.to ([92.243.29.197]:34142)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <nchip@kos.to>) id 1NGUTx-0002YQ-FU
	for qemu-devel@nongnu.org; Fri, 04 Dec 2009 04:29:45 -0500
Date: Fri, 4 Dec 2009 11:29:38 +0200
From: Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH] linux-user: use realpath for emulation
	dir paths
Message-ID: <20091204092938.GA23929@kos.to>
References: <1254486336.1738.30.camel@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1254486336.1738.30.camel@localhost.localdomain>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: qemu-devel@nongnu.org

On Fri, Oct 02, 2009 at 02:25:36PM +0200, Paul Bolle wrote:
> Note that I have some reservations about the current init_paths() and
> path() code:
> - their names seem to confusing. Maybe those should be init_base() and
> base() or something similar;
> - why does init_paths() copy all filenames in the emulation dir (at
> least, that what it seems to do)? Try something silly like
> "-L /home/../" to see what I mean ...
> - and why does path() return the original filename if that file isn't
> found in the emulation dir? That looks like a nice source for confusing
> behavior or crashes, as that means an identical named file (but using
> the regular root) will then be used.

Yeah, all that is a big mess and should be cleaned up. At the moment it
is all too easy to get init_paths to recurse forever..