From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NGWeX-0005zR-Ut for qemu-devel@nongnu.org; Fri, 04 Dec 2009 06:48:50 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NGWeS-0005yr-W1 for qemu-devel@nongnu.org; Fri, 04 Dec 2009 06:48:49 -0500 Received: from [199.232.76.173] (port=39520 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NGWeS-0005yj-IJ for qemu-devel@nongnu.org; Fri, 04 Dec 2009 06:48:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10667) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NGWeS-0005xG-6H for qemu-devel@nongnu.org; Fri, 04 Dec 2009 06:48:44 -0500 Date: Fri, 4 Dec 2009 09:48:32 -0200 From: Luiz Capitulino Subject: Re: [Qemu-devel] Staging update (0.12 pending freeze) Message-ID: <20091204094832.77f719c5@doriath> In-Reply-To: <4B18EFDF.6000000@redhat.com> References: <4B1699D3.8010908@codemonkey.ws> <4B17B057.1070004@redhat.com> <4B1847EE.7060706@codemonkey.ws> <20091203215350.7159df5d@doriath> <4B185200.4050301@codemonkey.ws> <4B18EFDF.6000000@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: "qemu-devel@nongnu.org" On Fri, 04 Dec 2009 12:17:51 +0100 Gerd Hoffmann wrote: > On 12/04/09 01:04, Anthony Liguori wrote: > > Problem is, control is not a property of the character device. To > > express this in a consistent way with everything else, you would have to > > make this QemuOpts-like so it would look like > > > > -monitor control,device=tcp:localhost:444,server > > > > But so far, the monitor, serial, parallel, etc. devices don't take > > QemuOpts. > > > > OTH, having: > > > > -qmp tcp:localhost:444,server > > I think we should create a new option for monitor configuration, like this: > > -mon mode={control,readline},chardev=,more-options-here > > So you'll create a qmp monitor socket this way: > > -chardev socket,path=/tmp/qmpsock,id=qmp,server,nowait > -mon mode=control,chardev=qmp > > Then the -monitor switch will be legacy/convinience syntax for a > readline monitor with auto-created chardev named 'monitor'. I like this. I believe it wouldn't be difficult for you to rebase your series on top of staging with an incremental patch for QMP, right?