From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NGYrb-0003Mp-DS
	for qemu-devel@nongnu.org; Fri, 04 Dec 2009 09:10:27 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NGYrW-0003Fq-I7
	for qemu-devel@nongnu.org; Fri, 04 Dec 2009 09:10:26 -0500
Received: from [199.232.76.173] (port=34972 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NGYrW-0003FW-CX
	for qemu-devel@nongnu.org; Fri, 04 Dec 2009 09:10:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40836)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1NGYrV-0006KV-SD
	for qemu-devel@nongnu.org; Fri, 04 Dec 2009 09:10:22 -0500
Date: Fri, 4 Dec 2009 16:10:04 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20091204141004.GA8707@redhat.com>
References: <1259922793-20433-1-git-send-email-agraf@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1259922793-20433-1-git-send-email-agraf@suse.de>
Subject: [Qemu-devel] Re: [PATCH v2] [0.12] Map BIOS f-segment as RAM,
	not as ROM
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Kevin O'Connor <kevin@koconnor.net>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>, Sebastian Herbszt <herbszt@gmx.de>

On Fri, Dec 04, 2009 at 11:33:13AM +0100, Alexander Graf wrote:
> SeaBIOS needs to write to the f-segment. So it needs to have some way to set
> that from read-only to read-write, write in it and when it's done set it to
> read-only again.
> 
> On PCI we have a mechanism for that. The ISA machine does not though. To stay
> regression free and happily enable users to continue using the -M isapc machine
> let's just map it as RAM. The BIOS on PCI will set it to r/o later either way.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>
> 
Looks fine to me. Guest will be able to overwrite BIOS, but I don't
think we should care about this too much. On KVM all ROM slots are
writable anyway.

> ---
> 
> v1 -> v2:
> 
>   - always map r/w
> ---
>  hw/pc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/pc.c b/hw/pc.c
> index 8c1b7ea..b5dabdd 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -1075,7 +1075,7 @@ static void pc_init1(ram_addr_t ram_size,
>          isa_bios_size = 128 * 1024;
>      cpu_register_physical_memory(0x100000 - isa_bios_size,
>                                   isa_bios_size,
> -                                 (bios_offset + bios_size - isa_bios_size) | IO_MEM_ROM);
> +                                 (bios_offset + bios_size - isa_bios_size));
>  
>  
>  
> -- 
> 1.6.0.2

--
			Gleb.