From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NGcFU-0001Ey-LT for qemu-devel@nongnu.org; Fri, 04 Dec 2009 12:47:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NGcFN-00016y-Jv for qemu-devel@nongnu.org; Fri, 04 Dec 2009 12:47:17 -0500 Received: from [199.232.76.173] (port=35655 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NGcFN-00016g-9q for qemu-devel@nongnu.org; Fri, 04 Dec 2009 12:47:13 -0500 Received: from mx20.gnu.org ([199.232.41.8]:10488) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NGcFN-0002RU-9P for qemu-devel@nongnu.org; Fri, 04 Dec 2009 12:47:13 -0500 Received: from mail.codesourcery.com ([38.113.113.100]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NGcFK-0008P8-Dg for qemu-devel@nongnu.org; Fri, 04 Dec 2009 12:47:10 -0500 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] Get coding style closer to the real world Date: Fri, 4 Dec 2009 17:47:06 +0000 References: <1259618155-4217-1-git-send-email-agraf@suse.de> In-Reply-To: <1259618155-4217-1-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <200912041747.06776.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Monday 30 November 2009, Alexander Graf wrote: > Currently we have this stupid role of disallowing: > > if (r) > break; This has been discussed to death several times, in several different paces, and with no clear resolution or consensus, so I'm going to make an executive decision: The coding style stays as-is. Braces are required. Please ensure that all patches follow the coding style. There may be exceptions, but there should be a *good* reason for deviation. If there are real problems or ambiguities in the coding style then I am willing to consider fixing it. This particular change meets neither criteria. By picking a single coding style we've pretty much guaranteed that most people will disagree with some of it. IMO consistency is more important. Paul