* [Qemu-devel] run make defconfig
@ 2009-12-07 9:42 Michael S. Tsirkin
2009-12-07 17:19 ` Anthony Liguori
0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2009-12-07 9:42 UTC (permalink / raw)
To: qemu-devel
OK, I got the "Run make defconfig" message again.
I think it used to be re-run automatically: why
are we asking the user to do it manually now?
It's pretty annoying ...
Also:
$ make defconfig
GEN x86_64-softmmu/config-devices.mak
WARNING: x86_64-softmmu/config-devices.mak out of date.
Run "make defconfig" to regenerate.
config-host.mak is out-of-date, running configure
Install prefix /home/mst/qemu
BIOS directory /home/mst/qemu/share/qemu
binary directory /home/mst/qemu/bin
Manual directory /home/mst/qemu/share/man
ELF interp prefix /usr/gnemul/qemu-%M
Source path /scm/qemu
C compiler gcc
Host C compiler gcc
CFLAGS -O2 -g
QEMU_CFLAGS -Werror -m32 -Wold-style-definition -Wold-style-declaration -I. -I$(SRC_PATH) -U_FORTIFY_SOURCE -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing
LDFLAGS -Wl,--warn-common -m32 -g
make make
install install
host CPU i386
host big endian no
target list x86_64-softmmu
tcg debug enabled no
gprof enabled no
sparse enabled no
strip binaries yes
profiler no
static build no
-Werror enabled yes
SDL support yes
curses support yes
curl support yes
check support no
mingw32 support no
Audio drivers oss
Extra audio cards ac97 es1370 sb16
Block whitelist
Mixer emulation no
VNC TLS support no
VNC SASL support no
xen support no
brlapi support no
bluez support no
Documentation no
NPTL support yes
GUEST_BASE yes
PIE user targets no
vde support no
IO thread no
Linux AIO support no
Install blobs yes
KVM support yes
fdt support no
preadv support yes
fdatasync yes
uuid support yes
GEN x86_64-softmmu/config-devices.mak
WARNING: x86_64-softmmu/config-devices.mak out of date.
Run "make defconfig" to regenerate.
rm -f config-all-devices.mak x86_64-softmmu/config-devices.mak
I *am* running make defconfig. Why does it tell me to run make defconfig?
Thanks,
--
MST
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] run make defconfig
2009-12-07 9:42 [Qemu-devel] run make defconfig Michael S. Tsirkin
@ 2009-12-07 17:19 ` Anthony Liguori
2009-12-07 19:22 ` [Qemu-devel] " Michael S. Tsirkin
0 siblings, 1 reply; 3+ messages in thread
From: Anthony Liguori @ 2009-12-07 17:19 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel, Juan Quintela
Michael S. Tsirkin wrote:
> OK, I got the "Run make defconfig" message again.
> I think it used to be re-run automatically: why
> are we asking the user to do it manually now?
>
It's buggy. defconfig should only be needed when a new config option is
added and the old config doesn't contain it yet.
But we get this message often when a new config option has not been
added. I suspect it has something to do with checks on accessed time
against configure and config*. We probably need to be smarter than that.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: run make defconfig
2009-12-07 17:19 ` Anthony Liguori
@ 2009-12-07 19:22 ` Michael S. Tsirkin
0 siblings, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2009-12-07 19:22 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, Juan Quintela
On Mon, Dec 07, 2009 at 11:19:26AM -0600, Anthony Liguori wrote:
> Michael S. Tsirkin wrote:
>> OK, I got the "Run make defconfig" message again.
>> I think it used to be re-run automatically: why
>> are we asking the user to do it manually now?
>>
> It's buggy. defconfig should only be needed when a new config option is
> added and the old config doesn't contain it yet.
>
> But we get this message often when a new config option has not been
> added. I suspect it has something to do with checks on accessed time
> against configure and config*. We probably need to be smarter than that.
>
> Regards,
>
> Anthony Liguori
Could you tell me what is it supposed to do?
Here's code with my commentary:
config-all-devices.mak: $(SUBDIR_DEVICES_MAK)
$(call quiet-command,cat $(SUBDIR_DEVICES_MAK) | grep =y | sort -u > $@," GEN $@")
# so there's config-all-devices.mak which includes all =y lines from SUBDIR_DEVICES_MAK.
%/config-devices.mak: default-configs/%.mak
# this is run if
# default-configs/%.mak exists and %/config-devices.mak
# is older than default-configs/%.mak
$(call quiet-command,cat $< > $@.tmp, " GEN $@")
# simply cat default-configs/%.mak to a temporary file
@if test -f $@ ; then \
# check whether %/config-devices.mak exists
echo "WARNING: $@ out of date." ;\
echo "Run \"make defconfig\" to regenerate." ; \
rm $@.tmp ; \
#if yes tell user to run make defconfig and remove temporary
# so why generate in the first place?
else \
mv $@.tmp $@ ; \
#if no move temporary to %/config-devices.mak
fi
defconfig:
rm -f config-all-devices.mak $(SUBDIR_DEVICES_MAK)
# this removes config-all-devices.mak and all SUBDIR_DEVICES_MAK
Now in targets, we have include config-devices.mak
So my conclusions are:
- The only way to generate config-devices.mak seems to be to copy default-configs.mak
- We get warning each time timestamp for default configs changes.
- Annoyingly, this warning will be present when you run make defconfig itself
or when you run make clean
Proposal: why don't we just make %/config-devices.mak include
default-configs/%.mak? No copy will be necessary.
--
MST
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-07 19:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-07 9:42 [Qemu-devel] run make defconfig Michael S. Tsirkin
2009-12-07 17:19 ` Anthony Liguori
2009-12-07 19:22 ` [Qemu-devel] " Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).