Re: [Qemu-devel] [PATCH 19/19] VNC: Convert do_info_vnc() to QObject

[Luiz Capitulino <lcapitulino@redhat.com>]

On Thu, 10 Dec 2009 11:34:37 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> > +/**
> > + * do_info_vnc(): Show VNC server information
> > + *
> > + * Return a QDict with server information. Connected clients are returned
> > + * as a QList of QDicts.
> > + *
> > + * The main QDict contains the following:
> > + *
> > + * - "status": "disabled" or "enabled"
> > + * - "host": server's IP address
> > + * - "service": server's port number
> > + * - "auth": authentication method (optional)
> > + * - "clients": a QList of all connected clients
> > + *
> > + * Clients are described by a QDict, with the following information:
> > + *
> > + * - "host": client's IP address
> > + * - "service": client's port number
> > + * - "x509 dname": TLS dname (optional)
> 
> Sure you want dict keys with spaces?  I'd prefer "x509-dname".

 I don't think it's a big deal because this string will never
change, but would be good to come with a standard style for
dict keys (at least for the protocol).

 I'm ok with either way.