From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NIhdA-0002cQ-Bs
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 06:56:24 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NIhd1-0002Y3-Ta
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 06:56:20 -0500
Received: from [199.232.76.173] (port=47547 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NIhd0-0002XW-SA
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 06:56:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:18099)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NIhd0-0000yB-CL
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 06:56:14 -0500
Date: Thu, 10 Dec 2009 09:56:06 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 19/19] VNC: Convert do_info_vnc() to QObject
Message-ID: <20091210095606.4df68209@doriath>
In-Reply-To: <m37hsvw20y.fsf@crossbow.pond.sub.org>
References: <1260376078-8694-1-git-send-email-lcapitulino@redhat.com>
	<1260376078-8694-20-git-send-email-lcapitulino@redhat.com>
	<m37hsvw20y.fsf@crossbow.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Thu, 10 Dec 2009 11:34:37 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> > +/**
> > + * do_info_vnc(): Show VNC server information
> > + *
> > + * Return a QDict with server information. Connected clients are returned
> > + * as a QList of QDicts.
> > + *
> > + * The main QDict contains the following:
> > + *
> > + * - "status": "disabled" or "enabled"
> > + * - "host": server's IP address
> > + * - "service": server's port number
> > + * - "auth": authentication method (optional)
> > + * - "clients": a QList of all connected clients
> > + *
> > + * Clients are described by a QDict, with the following information:
> > + *
> > + * - "host": client's IP address
> > + * - "service": client's port number
> > + * - "x509 dname": TLS dname (optional)
> 
> Sure you want dict keys with spaces?  I'd prefer "x509-dname".

 I don't think it's a big deal because this string will never
change, but would be good to come with a standard style for
dict keys (at least for the protocol).

 I'm ok with either way.