From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NIhhf-000439-9b
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 07:01:03 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NIhhX-00041P-Gx
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 07:00:59 -0500
Received: from [199.232.76.173] (port=38077 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NIhhX-000418-3E
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 07:00:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:6022)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NIhhW-0001Ne-Kh
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 07:00:54 -0500
Date: Thu, 10 Dec 2009 10:00:46 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 06/19] monitor: do_info_cpus(): Use QBool
Message-ID: <20091210100046.066ade91@doriath>
In-Reply-To: <m3ws0vumzi.fsf@crossbow.pond.sub.org>
References: <1260376078-8694-1-git-send-email-lcapitulino@redhat.com>
	<1260376078-8694-7-git-send-email-lcapitulino@redhat.com>
	<m3ws0vumzi.fsf@crossbow.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Thu, 10 Dec 2009 11:44:49 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > While there update the documentation as well.
> >
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  monitor.c |   39 ++++++++++++++++++++++++++-------------
> >  1 files changed, 26 insertions(+), 13 deletions(-)
> >
> > diff --git a/monitor.c b/monitor.c
> > index aa56ec7..8729535 100644
> > --- a/monitor.c
> > +++ b/monitor.c
> [...]
> > @@ -650,12 +652,22 @@ static void monitor_print_cpus(Monitor *mon, const QObject *data)
> >  /**
> >   * do_info_cpus(): Show CPU information
> >   *
> > - * Return a QList with a QDict for each CPU.
> > + * Return a QList. Each CPU is represented by a QDict, which contains:
> >   *
> > - * For example:
> > + * - "cpu": CPU index
> > + * - "current": true if this is the current CPU, false otherwise
> > + * - "halted": true if the cpu is halted, false otherwise
> > + * - Current program counter, in decimal. The key name depends on
> 
> Do we want to specify the base for numbers in the JSON?
> 
> If yes, why not use decimal everywhere?
> 
> Aside, if we use hexadecimal in JSON at all, then I'd prefer addresses
> to be hexadecimal.

 Makes sense, I was in doubt about how I should represent this but addresses
should always be hexadecimal.

 What about adding a section to do the spec (or creating a new
document) describing the protocol style?