From: Luiz Capitulino <lcapitulino@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] e1000: fix init values for command register
Date: Thu, 10 Dec 2009 11:03:55 -0200 [thread overview]
Message-ID: <20091210110355.5f94219d@doriath> (raw)
In-Reply-To: <20091209203537.GA7836@redhat.com>
On Wed, 9 Dec 2009 22:35:37 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> Command register for e1000 was initialized to
> values out of spec: all of bus master,
> io, memory and interrupt disable bits were set.
>
> This breaks the device now that we actually respect
> the interrupt disable bit, unless the guest
> happens to clear it. Fix, and make the device
> more spec compliant, by not touching
> the default.
>
> There are implications for migration
> from old qemu as well, will be addressed
> separately.
FWIW, I've tested the others network cards (only for the slirp case)
and they worked fine.
next prev parent reply other threads:[~2009-12-10 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 20:35 [Qemu-devel] [PATCH] e1000: fix init values for command register Michael S. Tsirkin
2009-12-10 13:03 ` Luiz Capitulino [this message]
2009-12-10 18:14 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210110355.5f94219d@doriath \
--to=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).