From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NIigr-0000ut-FL for qemu-devel@nongnu.org; Thu, 10 Dec 2009 08:04:17 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NIigh-0000rM-Vb for qemu-devel@nongnu.org; Thu, 10 Dec 2009 08:04:15 -0500 Received: from [199.232.76.173] (port=38547 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIigh-0000rA-DN for qemu-devel@nongnu.org; Thu, 10 Dec 2009 08:04:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19083) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NIigh-0006bW-6J for qemu-devel@nongnu.org; Thu, 10 Dec 2009 08:04:07 -0500 Date: Thu, 10 Dec 2009 11:03:55 -0200 From: Luiz Capitulino Message-ID: <20091210110355.5f94219d@doriath> In-Reply-To: <20091209203537.GA7836@redhat.com> References: <20091209203537.GA7836@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] e1000: fix init values for command register List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On Wed, 9 Dec 2009 22:35:37 +0200 "Michael S. Tsirkin" wrote: > Command register for e1000 was initialized to > values out of spec: all of bus master, > io, memory and interrupt disable bits were set. > > This breaks the device now that we actually respect > the interrupt disable bit, unless the guest > happens to clear it. Fix, and make the device > more spec compliant, by not touching > the default. > > There are implications for migration > from old qemu as well, will be addressed > separately. FWIW, I've tested the others network cards (only for the slirp case) and they worked fine.