From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NIhtE-000235-Oo for qemu-devel@nongnu.org; Thu, 10 Dec 2009 07:13:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NIht9-0001xh-S5 for qemu-devel@nongnu.org; Thu, 10 Dec 2009 07:13:00 -0500 Received: from [199.232.76.173] (port=52079 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIht9-0001xa-ND for qemu-devel@nongnu.org; Thu, 10 Dec 2009 07:12:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:2452) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NIht9-0002GK-Dj for qemu-devel@nongnu.org; Thu, 10 Dec 2009 07:12:55 -0500 Date: Thu, 10 Dec 2009 12:12:52 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH 19/19] VNC: Convert do_info_vnc() to QObject Message-ID: <20091210121252.GN13534@redhat.com> References: <1260376078-8694-1-git-send-email-lcapitulino@redhat.com> <1260376078-8694-20-git-send-email-lcapitulino@redhat.com> <20091210095606.4df68209@doriath> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091210095606.4df68209@doriath> Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, Markus Armbruster , qemu-devel@nongnu.org On Thu, Dec 10, 2009 at 09:56:06AM -0200, Luiz Capitulino wrote: > On Thu, 10 Dec 2009 11:34:37 +0100 > Markus Armbruster wrote: > > > > +/** > > > + * do_info_vnc(): Show VNC server information > > > + * > > > + * Return a QDict with server information. Connected clients are returned > > > + * as a QList of QDicts. > > > + * > > > + * The main QDict contains the following: > > > + * > > > + * - "status": "disabled" or "enabled" > > > + * - "host": server's IP address > > > + * - "service": server's port number > > > + * - "auth": authentication method (optional) > > > + * - "clients": a QList of all connected clients > > > + * > > > + * Clients are described by a QDict, with the following information: > > > + * > > > + * - "host": client's IP address > > > + * - "service": client's port number > > > + * - "x509 dname": TLS dname (optional) > > > > Sure you want dict keys with spaces? I'd prefer "x509-dname". > > I don't think it's a big deal because this string will never > change, but would be good to come with a standard style for > dict keys (at least for the protocol). I agree with Markus, that it is nicer to avoid spaces in the dict keys, even if technically it is allowed. I'd vote for x509-dname too. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|