qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org,
	Anthony Liguori <aliguori@linux.vnet.ibm.com>,
	Avi Kivity <avi@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject
Date: Thu, 10 Dec 2009 15:49:20 -0200	[thread overview]
Message-ID: <20091210154920.4eba76bb@doriath> (raw)
In-Reply-To: <20091210173813.GA23219@redhat.com>

On Thu, 10 Dec 2009 17:38:13 +0000
"Daniel P. Berrange" <berrange@redhat.com> wrote:

> On Thu, Dec 10, 2009 at 02:54:57PM -0200, Luiz Capitulino wrote:

> >  An option we have is: libvirt actually uses four or five of those
> > info commands. So, we could drop all the rest and guarantee that
> > only those libvirt ones are 100% correct.
> 
> Please don't do that.

 I won't.

> libvirt is adding support for new features all the
> time. I don't want to be in the situation where we can't add a new feature
> because it is missing in the JSON impl. If we're going to provide a supported
> JSON monitor it needs to have all the commands converted, otherwise we'll
> have to stick with using the text based monitor.

 But 0.12 won't have all commands converted, this page has a listing
of what we're going to have:

http://www.linux-kvm.org/page/MonitorProtocol#Conversion_work_detailed_status

 'converted' and 'merged' are guaranteed, Markus did some work and enabled
one or two which are not there.

 I know that the usb and net ones are vital for you, I've patches enabling
them but their error handling is very difficult to get right.

  reply	other threads:[~2009-12-10 17:49 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-09 16:27 [Qemu-devel] [FOR 0.12 v3 00/19]: info handlers conversions to QObject Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 01/19] Introduce qemu-objects.h header file Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 02/19] Makefile: move QObject objs to their own entry Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 03/19] QDict: Introduce qdict_get_qbool() Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 04/19] QDict: Introduce qdict_get_qlist() Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 05/19] monitor: Fix do_info_balloon() output Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 06/19] monitor: do_info_cpus(): Use QBool Luiz Capitulino
2009-12-10 10:44   ` Markus Armbruster
2009-12-10 12:00     ` Luiz Capitulino
2009-12-10 13:01     ` Anthony Liguori
2009-12-10 13:05       ` Luiz Capitulino
2009-12-10 13:08         ` Anthony Liguori
2009-12-10 13:10         ` Anthony Liguori
2009-12-10 13:22       ` Markus Armbruster
2009-12-09 16:27 ` [Qemu-devel] [PATCH 07/19] monitor: do_info_version(): Use QDict Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 08/19] monitor: Convert do_info_status() to QObject Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 09/19] monitor: Convert do_info_kvm() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() " Luiz Capitulino
2009-12-10 10:09   ` Markus Armbruster
2009-12-10 11:52     ` Luiz Capitulino
2009-12-10 12:56       ` Anthony Liguori
2009-12-10 15:55         ` Avi Kivity
2009-12-10 15:57           ` Avi Kivity
2009-12-10 16:03           ` Anthony Liguori
2009-12-10 16:10             ` Avi Kivity
2009-12-10 16:20               ` Anthony Liguori
2009-12-10 16:24                 ` Avi Kivity
2009-12-10 16:54                   ` Luiz Capitulino
2009-12-10 17:02                     ` Avi Kivity
2009-12-10 17:12                       ` Luiz Capitulino
2009-12-10 17:38                     ` Daniel P. Berrange
2009-12-10 17:49                       ` Luiz Capitulino [this message]
2009-12-10 18:00                         ` Daniel P. Berrange
2009-12-11 12:54                           ` Luiz Capitulino
2009-12-11 13:14                             ` Anthony Liguori
2009-12-11 13:20                       ` Anthony Liguori
2009-12-11 19:46                         ` Daniel P. Berrange
2009-12-11 13:18                     ` Anthony Liguori
2009-12-11 13:27                       ` Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 11/19] monitor: Convert do_info_hpet() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 12/19] monitor: Convert do_info_uuid() " Luiz Capitulino
2009-12-10 10:14   ` Markus Armbruster
2009-12-09 16:27 ` [Qemu-devel] [PATCH 13/19] monitor: Convert do_info_mice() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 14/19] migration: Convert do_info_migrate() " Luiz Capitulino
2009-12-10 10:19   ` Markus Armbruster
2009-12-09 16:27 ` [Qemu-devel] [PATCH 15/19] block: Convert bdrv_info() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 16/19] block: Convert bdrv_info_stats() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 17/19] char: Convert qemu_chr_info() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 18/19] PCI: Convert pci_device_hot_add() " Luiz Capitulino
2009-12-09 16:27 ` [Qemu-devel] [PATCH 19/19] VNC: Convert do_info_vnc() " Luiz Capitulino
2009-12-10 10:34   ` Markus Armbruster
2009-12-10 11:56     ` Luiz Capitulino
2009-12-10 12:12       ` Daniel P. Berrange
2009-12-10 13:00     ` Anthony Liguori
2009-12-10 10:49 ` [Qemu-devel] [FOR 0.12 v3 00/19]: info handlers conversions " Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091210154920.4eba76bb@doriath \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@linux.vnet.ibm.com \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).