From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NInVL-0003W3-Vj for qemu-devel@nongnu.org; Thu, 10 Dec 2009 13:12:44 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NInVG-0003QP-Kd for qemu-devel@nongnu.org; Thu, 10 Dec 2009 13:12:42 -0500 Received: from [199.232.76.173] (port=58659 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NInVG-0003QB-8R for qemu-devel@nongnu.org; Thu, 10 Dec 2009 13:12:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63525) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NInVG-0003Zj-Ng for qemu-devel@nongnu.org; Thu, 10 Dec 2009 13:12:39 -0500 Date: Thu, 10 Dec 2009 20:09:52 +0200 From: "Michael S. Tsirkin" Message-ID: <20091210180952.GC25707@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [Qemu-devel] [PATCH 02/17] ne2000: switch to symbolic names for pci registers List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , qemu-devel@nongnu.org No functional changes. I verified that the generated binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/ne2000.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/ne2000.c b/hw/ne2000.c index d1416cf..78fe14f 100644 --- a/hw/ne2000.c +++ b/hw/ne2000.c @@ -724,7 +724,8 @@ static int pci_ne2000_init(PCIDevice *pci_dev) pci_config_set_device_id(pci_conf, PCI_DEVICE_ID_REALTEK_8029); pci_config_set_class(pci_conf, PCI_CLASS_NETWORK_ETHERNET); pci_conf[PCI_HEADER_TYPE] = PCI_HEADER_TYPE_NORMAL; // header_type - pci_conf[0x3d] = 1; // interrupt pin 0 + /* TODO: RST# value should be 0. PCI spec 6.2.4 */ + pci_conf[PCI_INTERRUPT_PIN] = 1; // interrupt pin 0 pci_register_bar(&d->dev, 0, 0x100, PCI_BASE_ADDRESS_SPACE_IO, ne2000_map); -- 1.6.6.rc1.43.gf55cc