From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 00/17] pci: switch a ton of drivers to symbolic names
Date: Thu, 10 Dec 2009 18:28:39 +0000 [thread overview]
Message-ID: <200912101828.39821.paul@codesourcery.com> (raw)
In-Reply-To: <20091210180939.GA25707@redhat.com>
On Thursday 10 December 2009, Michael S. Tsirkin wrote:
> The recent e1000 bug made the important of using
> symbolic macros for pci config access clear for me.
> So I started going over drivers and converting
> to symbolic constants instead of hard-coded ones.
> I did a large part until I run out of steam.
> Maybe some brave soul will take up converting
> the rest of them, or maybe I will: note that
> when converting bridges one should be careful
> to use bridge macros where appropriate.
Seeing as you're introducing a huge amount of churn, wouldn't it be better to
come up with a sane abstraction for initializing the the PCI config data (c.f.
pci_config_set_vendor_id)?
Paul
next prev parent reply other threads:[~2009-12-10 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 18:09 [Qemu-devel] [PATCH 00/17] pci: switch a ton of drivers to symbolic names Michael S. Tsirkin
2009-12-10 18:17 ` Glauber Costa
2009-12-10 18:28 ` Paul Brook [this message]
2009-12-11 10:26 ` Michael S. Tsirkin
2009-12-12 15:46 ` [Qemu-devel] " Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912101828.39821.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).