From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NInl1-0006IX-Og
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 13:28:55 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NInkx-0006Eh-B2
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 13:28:55 -0500
Received: from [199.232.76.173] (port=51864 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NInkx-0006EZ-3W
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 13:28:51 -0500
Received: from mx20.gnu.org ([199.232.41.8]:27751)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1NInkx-0004oj-Or
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 13:28:51 -0500
Received: from mail.codesourcery.com ([38.113.113.100])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1NInkt-0000Pg-SD
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 13:28:48 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 00/17] pci: switch a ton of drivers to
	symbolic names
Date: Thu, 10 Dec 2009 18:28:39 +0000
References: <20091210180939.GA25707@redhat.com>
In-Reply-To: <20091210180939.GA25707@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200912101828.39821.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>

On Thursday 10 December 2009, Michael S. Tsirkin wrote:
> The recent e1000 bug made the important of using
> symbolic macros for pci config access clear for me.
> So I started going over drivers and converting
> to symbolic constants instead of hard-coded ones.
> I did a large part until I run out of steam.
> Maybe some brave soul will take up converting
> the rest of them, or maybe I will: note that
> when converting bridges one should be careful
> to use bridge macros where appropriate.

Seeing as you're introducing a huge amount of churn, wouldn't it be better to 
come up with a sane abstraction for initializing the the PCI config data (c.f. 
pci_config_set_vendor_id)?

Paul