From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NJBRZ-0007vE-9L for qemu-devel@nongnu.org; Fri, 11 Dec 2009 14:46:25 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NJBRU-0007o4-2n for qemu-devel@nongnu.org; Fri, 11 Dec 2009 14:46:24 -0500 Received: from [199.232.76.173] (port=34134 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NJBRT-0007nb-Tt for qemu-devel@nongnu.org; Fri, 11 Dec 2009 14:46:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20619) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NJBRT-0005iK-BV for qemu-devel@nongnu.org; Fri, 11 Dec 2009 14:46:19 -0500 Date: Fri, 11 Dec 2009 19:46:12 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to QObject Message-ID: <20091211194612.GA21297@redhat.com> References: <20091210095237.38cafe5c@doriath> <4B20F003.6070409@linux.vnet.ibm.com> <4B2119F9.6010003@redhat.com> <4B211BE2.60907@linux.vnet.ibm.com> <4B211D6F.7020906@redhat.com> <4B211FDF.4070509@linux.vnet.ibm.com> <4B2120C6.1020004@redhat.com> <20091210145457.25ba1f09@doriath> <20091210173813.GA23219@redhat.com> <4B22470C.7060702@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B22470C.7060702@linux.vnet.ibm.com> Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Markus Armbruster , Avi Kivity , Luiz Capitulino On Fri, Dec 11, 2009 at 07:20:12AM -0600, Anthony Liguori wrote: > Daniel P. Berrange wrote: > >Please don't do that. libvirt is adding support for new features all the > >time. I don't want to be in the situation where we can't add a new feature > >because it is missing in the JSON impl. If we're going to provide a > >supported > >JSON monitor it needs to have all the commands converted, otherwise we'll > >have to stick with using the text based monitor. > > > > I would suggest that for 0.12, libvirt not use QMP. It should wait > until 0.13 to convert over to QMP since we should have a full conversion > by then. I agree, given the time lines involved its not practical for us to switch to QMP in 0.12, so we'll wait until 0.13. On the plus side we've got all the QMP code in libvirt GIT now, so we can make sure that 0.13 is very well tested when time comes for its release :-) Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|