From: "Michael S. Tsirkin" <mst@redhat.com>
To: Juan Quintela <quintela@trasno.org>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] virtio: rename features -> guest_features
Date: Sun, 13 Dec 2009 22:34:04 +0200 [thread overview]
Message-ID: <20091213203403.GA25769@redhat.com> (raw)
In-Reply-To: <m3ws0qd3dk.fsf@neno.neno>
On Sun, Dec 13, 2009 at 09:29:27PM +0100, Juan Quintela wrote:
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > Rename features->guest_features. This is
> > what they are, avoid confusion with
> > host features which we also need to keep around.
>
> ....
>
> > case SYBORG_VIRTIO_GUEST_FEATURES:
> > if (vdev->set_features)
> > vdev->set_features(vdev, value);
>
> Once there, this should rename this to set_guest_features() also for consistency?
>
> Later, Juan.
We can do this. It's less important for me because we don't
need to add set_host_features anytime soon :)
prev parent reply other threads:[~2009-12-13 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-13 14:55 [Qemu-devel] [PATCH] virtio: rename features -> guest_features Michael S. Tsirkin
[not found] ` <m3ws0qd3dk.fsf@neno.neno>
2009-12-13 20:34 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091213203403.GA25769@redhat.com \
--to=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@trasno.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).