From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NJvBY-0001jp-8t
	for qemu-devel@nongnu.org; Sun, 13 Dec 2009 15:36:56 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NJvBT-0001jL-Vr
	for qemu-devel@nongnu.org; Sun, 13 Dec 2009 15:36:55 -0500
Received: from [199.232.76.173] (port=52472 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NJvBT-0001jH-OT
	for qemu-devel@nongnu.org; Sun, 13 Dec 2009 15:36:51 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34196)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NJvBT-0006OM-9F
	for qemu-devel@nongnu.org; Sun, 13 Dec 2009 15:36:51 -0500
Date: Sun, 13 Dec 2009 22:34:04 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091213203403.GA25769@redhat.com>
References: <20091213145513.GA11322@redhat.com> <m3ws0qd3dk.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3ws0qd3dk.fsf@neno.neno>
Subject: [Qemu-devel] Re: [PATCH] virtio: rename features -> guest_features
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@trasno.org>
Cc: qemu-devel@nongnu.org

On Sun, Dec 13, 2009 at 09:29:27PM +0100, Juan Quintela wrote:
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > Rename features->guest_features. This is
> > what they are, avoid confusion with
> > host features which we also need to keep around.
> 
> ....
> 
> >      case SYBORG_VIRTIO_GUEST_FEATURES:
> >          if (vdev->set_features)
> >              vdev->set_features(vdev, value);
> 
> Once there, this should rename this to set_guest_features() also for consistency?
> 
> Later, Juan.

We can do this. It's less important for me because we don't
need to add set_host_features anytime soon :)