From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NK7Uv-0007ar-Mx for qemu-devel@nongnu.org; Mon, 14 Dec 2009 04:45:45 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NK7Ur-0007aK-0V for qemu-devel@nongnu.org; Mon, 14 Dec 2009 04:45:45 -0500 Received: from [199.232.76.173] (port=37664 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NK7Uq-0007aC-Ok for qemu-devel@nongnu.org; Mon, 14 Dec 2009 04:45:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62811) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NK7Uq-0000Hc-DO for qemu-devel@nongnu.org; Mon, 14 Dec 2009 04:45:40 -0500 Date: Mon, 14 Dec 2009 11:42:55 +0200 From: "Michael S. Tsirkin" Message-ID: <20091214094255.GA32140@redhat.com> References: <20091213204341.GA25823@redhat.com> <4B260846.9020503@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B260846.9020503@redhat.com> Subject: [Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Mon, Dec 14, 2009 at 10:41:26AM +0100, Gerd Hoffmann wrote: > On 12/13/09 21:43, Michael S. Tsirkin wrote: >> Add features property to virtio. This makes it >> possible to e.g. define machine without indirect >> buffer support, which is required for 0.10 >> compatibility. or without hardware checksum >> support, which is required for 0.11 compatibility. > > I'd suggest to add flags for the individual features to the drivers > which actually use it instead, so you'll have > > -device virtio-net-pci,hw-checksum=0 > > and > > -device virtio-blk-pci,indirect-buffers=0 > > cheers, > Gerd Hmm. I hoped to avoid it, there are lots of features so it's a lot of work and in practice, this will most likely be set by machine description ... -- MST