From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKBAN-00033M-5c
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 08:40:47 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKBAI-00031R-LS
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 08:40:46 -0500
Received: from [199.232.76.173] (port=54120 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKBAI-00031F-Av
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 08:40:42 -0500
Received: from mx1.redhat.com ([209.132.183.28]:22350)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NKBAH-0004n7-Or
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 08:40:42 -0500
Date: Mon, 14 Dec 2009 15:37:57 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091214133757.GG973@redhat.com>
References: <1260794906-30168-1-git-send-email-yamahata@valinux.co.jp>
	<1260794906-30168-9-git-send-email-yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1260794906-30168-9-git-send-email-yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH 08/11] acpi: use range helper function.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

On Mon, Dec 14, 2009 at 09:48:23PM +0900, Isaku Yamahata wrote:
> use range helper function in pm_write_config().
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/acpi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/acpi.c b/hw/acpi.c
> index 9a69e7d..ad72297 100644
> --- a/hw/acpi.c
> +++ b/hw/acpi.c
> @@ -437,7 +437,7 @@ static void pm_write_config(PCIDevice *d,
>                              uint32_t address, uint32_t val, int len)
>  {
>      pci_default_write_config(d, address, val, len);
> -    if (address == 0x80)
> +    if (range_covers_byte(address, len, 0x80))
>          pm_io_space_update((PIIX4PMState *)d);
>  }
>  
> -- 
> 1.6.5.4