From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKBP1-0006hl-64
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 08:55:55 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKBOw-0006fP-Jm
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 08:55:54 -0500
Received: from [199.232.76.173] (port=52396 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKBOw-0006fC-6y
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 08:55:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35954)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NKBOv-0006ix-Qt
	for qemu-devel@nongnu.org; Mon, 14 Dec 2009 08:55:50 -0500
Date: Mon, 14 Dec 2009 15:53:05 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091214135305.GL973@redhat.com>
References: <1260794906-30168-1-git-send-email-yamahata@valinux.co.jp>
	<1260794906-30168-5-git-send-email-yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1260794906-30168-5-git-send-email-yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH 04/11] pci: remove PCI_REVISION and
	PCI_SUBDEVICE_ID.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

On Mon, Dec 14, 2009 at 09:48:19PM +0900, Isaku Yamahata wrote:
> There is no user and they're obsolete. So remove them.
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

We are removing everything here later, is it worth it
to put in a separate patch?
Anyway:
Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/pci.h |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/pci.h b/hw/pci.h
> index 0309674..91f3809 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -154,9 +154,7 @@ typedef struct PCIIORegion {
>  #define PCI_CAP_LIST_ID		0	/* Capability ID */
>  #define PCI_CAP_LIST_NEXT	1	/* Next capability in the list */
>  
> -#define PCI_REVISION            0x08    /* obsolete, use PCI_REVISION_ID */
>  #define PCI_SUBSYSTEM_VENDOR_ID 0x2c
> -#define PCI_SUBDEVICE_ID        0x2e    /* obsolete, use PCI_SUBSYSTEM_ID */
>  
>  /* Bits in the PCI Status Register (PCI 2.3 spec) */
>  #define PCI_STATUS_RESERVED1	0x007
> -- 
> 1.6.5.4