From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKW7F-0005Yg-32
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 07:02:57 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKW79-0005UQ-RH
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 07:02:55 -0500
Received: from [199.232.76.173] (port=37627 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKW79-0005UF-Gb
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 07:02:51 -0500
Received: from mx1.redhat.com ([209.132.183.28]:62673)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NKW78-0000It-WE
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 07:02:51 -0500
Date: Tue, 15 Dec 2009 10:02:40 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/5] monitor: Catch printing to
	non-existent monitor
Message-ID: <20091215100240.333a1cf6@doriath>
In-Reply-To: <m3zl5kpo89.fsf@crossbow.pond.sub.org>
References: <1260824004-2941-1-git-send-email-lcapitulino@redhat.com>
	<1260824004-2941-6-git-send-email-lcapitulino@redhat.com>
	<m3zl5kpo89.fsf@crossbow.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Tue, 15 Dec 2009 10:42:46 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> Before the code motion, we throw QERR_UNDEFINED_ERROR on
> monitor_vprintf(NULL, ...).  Afterwards, we don't.  Could you explain
> why that's okay?

 We never did that. A call like that will just segfault QEMU
w/o this fix.