From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP
Date: Tue, 15 Dec 2009 10:08:10 -0200 [thread overview]
Message-ID: <20091215100810.3ba932a5@doriath> (raw)
In-Reply-To: <m3eimwpnow.fsf@crossbow.pond.sub.org>
On Tue, 15 Dec 2009 10:54:23 +0100
Markus Armbruster <armbru@redhat.com> wrote:
> Markus Armbruster <armbru@redhat.com> writes:
>
> > Luiz Capitulino <lcapitulino@redhat.com> writes:
> >
> >> The monitor_read_command() function is readline specific
> >> and should only be used when readline is available.
> >>
> >> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> >
> > I figure this bug breaks password entry (VNC and block) on non-readline
> > monitors. Suspect commit cde76ee1.
I can only assume that it didn't matter until now.
> PS: Subject is wrong. gdbserver_start() creates a monitor with
> MONITOR_USE_READLINE off, so it's not just QMP.
Ditto.
next prev parent reply other threads:[~2009-12-15 12:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 20:53 [Qemu-devel] [FOR 0.12 0/5]: Misc QMP related fixes Luiz Capitulino
2009-12-14 20:53 ` [Qemu-devel] [PATCH 1/5] QDict: Fix size update Luiz Capitulino
2009-12-14 20:53 ` [Qemu-devel] [PATCH 2/5] monitor: Use 'device' in eject Luiz Capitulino
2009-12-14 20:53 ` [Qemu-devel] [PATCH 3/5] monitor: do_balloon(): Check for errors Luiz Capitulino
2009-12-14 20:53 ` [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP Luiz Capitulino
2009-12-15 9:50 ` Markus Armbruster
2009-12-15 9:54 ` Markus Armbruster
2009-12-15 12:08 ` Luiz Capitulino [this message]
2009-12-15 14:03 ` Markus Armbruster
2009-12-15 14:17 ` [Qemu-devel] " Jan Kiszka
2009-12-14 20:53 ` [Qemu-devel] [PATCH 5/5] monitor: Catch printing to non-existent monitor Luiz Capitulino
2009-12-15 9:42 ` Markus Armbruster
2009-12-15 12:02 ` Luiz Capitulino
2009-12-15 13:56 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091215100810.3ba932a5@doriath \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).