From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKWCV-0001j2-6b
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 07:08:23 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKWCQ-0001g9-Aa
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 07:08:22 -0500
Received: from [199.232.76.173] (port=58391 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKWCQ-0001g4-22
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 07:08:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:29390)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NKWCP-0000p0-Cb
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 07:08:17 -0500
Date: Tue, 15 Dec 2009 10:08:10 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP
Message-ID: <20091215100810.3ba932a5@doriath>
In-Reply-To: <m3eimwpnow.fsf@crossbow.pond.sub.org>
References: <1260824004-2941-1-git-send-email-lcapitulino@redhat.com>
	<1260824004-2941-5-git-send-email-lcapitulino@redhat.com>
	<m3vdg8pnvs.fsf@crossbow.pond.sub.org>
	<m3eimwpnow.fsf@crossbow.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Tue, 15 Dec 2009 10:54:23 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> Markus Armbruster <armbru@redhat.com> writes:
> 
> > Luiz Capitulino <lcapitulino@redhat.com> writes:
> >
> >> The monitor_read_command() function is readline specific
> >> and should only be used when readline is available.
> >>
> >> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> >
> > I figure this bug breaks password entry (VNC and block) on non-readline
> > monitors.  Suspect commit cde76ee1.

 I can only assume that it didn't matter until now.

> PS: Subject is wrong.  gdbserver_start() creates a monitor with
> MONITOR_USE_READLINE off, so it's not just QMP.

 Ditto.