From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKZh2-000715-6L
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 10:52:08 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKZgx-0006yr-0Q
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 10:52:07 -0500
Received: from [199.232.76.173] (port=51112 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKZgw-0006yk-Qq
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 10:52:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:9308)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1NKZgw-00023v-In
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 10:52:02 -0500
Date: Tue, 15 Dec 2009 17:49:14 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20091215154913.GA23849@redhat.com>
References: <20091213213637.GA25879@redhat.com>
	<1260782734-11399-1-git-send-email-weil@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1260782734-11399-1-git-send-email-weil@mail.berlios.de>
Subject: [Qemu-devel] Re: [PATCH] eepro100: Better documentation for
	temporary data
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: aliguori@us.ibm.com, QEMU Developers <qemu-devel@nongnu.org>

On Mon, Dec 14, 2009 at 10:25:34AM +0100, Stefan Weil wrote:
> Michael S. Tsirkin suggested more documentation for
> two temporary status values. Well, here it is.
> 
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Looks good to me.

> ---
>  hw/eepro100.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/eepro100.c b/hw/eepro100.c
> index 22e5bed..5a77409 100644
> --- a/hw/eepro100.c
> +++ b/hw/eepro100.c
> @@ -213,9 +213,10 @@ typedef struct {
>      uint32_t ru_offset;         /* RU address offset */
>      uint32_t statsaddr;         /* pointer to eepro100_stats_t */
>  
> -    /* Temporary data. */
> -    eepro100_tx_t tx;
> -    uint32_t cb_address;
> +    /* Temporary status information (no need to save these values),
> +     * used while processing CU commands. */
> +    eepro100_tx_t tx;           /* transmit buffer descriptor */
> +    uint32_t cb_address;        /* = cu_base + cu_offset */
>  
>      /* Statistical counters. Also used for wake-up packet (i82559). */
>      eepro100_stats_t statistics;
> -- 
> 1.6.5