qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Naphtali Sprei <nsprei@redhat.com>,
	Christoph Hellwig <hch@lst.de>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive
Date: Thu, 17 Dec 2009 15:30:16 +0000	[thread overview]
Message-ID: <20091217153016.GF24967@shareable.org> (raw)
In-Reply-To: <4B2A3ED6.40908@redhat.com>

Kevin Wolf wrote:
> Am 17.12.2009 14:16, schrieb Jamie Lokier:
> You can decide to protect your images with the qemu readonly option and
> get the protection that qemu defines, or you take the permissions of the
> OS and get from the OS whatever the definition of that protection is
> (including write access for root).

Note that until the latest patch, "chmod 444" was the _the_ user
interface to this feature of qemu.  It's a bad interface, but it was
the only one available.  qemu is weird like that, having external
file permissions control an internal behaviour switch.

> qemu can't and shouldn't know that you use the OS's protection but
> actually don't quite mean what it's defined to be.

Then I concur with Christopher Hellwig, and we should drop the "auto"
behaviour entirely, and force the user interface to be the qemu
command line instead of "chmod" from now one.

-- Jamie

  reply	other threads:[~2009-12-17 15:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-14 13:35 [Qemu-devel] [PATCH] A different way to ask for readonly drive Naphtali Sprei
2009-12-14 15:53 ` Stefan Weil
2009-12-15 18:45   ` Jamie Lokier
2009-12-15 22:09     ` Stefan Weil
2009-12-17 10:50     ` Christoph Hellwig
2009-12-17 13:16       ` Jamie Lokier
2009-12-17 14:23         ` Kevin Wolf
2009-12-17 15:30           ` Jamie Lokier [this message]
2009-12-17 14:31         ` Markus Armbruster
2009-12-15 17:45 ` Kevin Wolf
2009-12-17 11:31 ` Richard W.M. Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091217153016.GF24967@shareable.org \
    --to=jamie@shareable.org \
    --cc=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=nsprei@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).