From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NMJHE-0007b5-KU for qemu-devel@nongnu.org; Sun, 20 Dec 2009 05:44:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NMJH9-0007Yf-5T for qemu-devel@nongnu.org; Sun, 20 Dec 2009 05:44:39 -0500 Received: from [199.232.76.173] (port=37318 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NMJH8-0007Yc-LS for qemu-devel@nongnu.org; Sun, 20 Dec 2009 05:44:34 -0500 Received: from mo-p00-ob.rzone.de ([81.169.146.162]:39259) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1NMJH8-0005K7-By for qemu-devel@nongnu.org; Sun, 20 Dec 2009 05:44:34 -0500 From: Kevin Wolf Subject: Re: [Qemu-devel] [PATCH 08/18] block/vvfat.c: fix warnings with _FORTIFY_SOURCE Date: Sun, 20 Dec 2009 11:48:15 +0100 References: <1261273167-3240-1-git-send-email-kirill@shutemov.name> <1261273167-3240-7-git-send-email-kirill@shutemov.name> <1261273167-3240-8-git-send-email-kirill@shutemov.name> In-Reply-To: <1261273167-3240-8-git-send-email-kirill@shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200912201148.15758@kevin-wolf.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Kirill A. Shutemov" Am Sonntag, 20. Dezember 2009 02:39 schrieb Kirill A. Shutemov: > CC block/vvfat.o > cc1: warnings being treated as errors > block/vvfat.c: In function 'commit_one_file': > block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result > make: *** [block/vvfat.o] Error 1 > CC block/vvfat.o > In file included from /usr/include/stdio.h:912, > from ./qemu-common.h:19, > from block/vvfat.c:27: > In function 'snprintf', > inlined from 'init_directories' at block/vvfat.c:871, > inlined from 'vvfat_open' at block/vvfat.c:1068: > /usr/include/bits/stdio2.h:65: error: call to __builtin___snprintf_chk will always overflow destination buffer > make: *** [block/vvfat.o] Error 1 > > Signed-off-by: Kirill A. Shutemov > --- > block/vvfat.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/block/vvfat.c b/block/vvfat.c > index 063f731..7b6a405 100644 > --- a/block/vvfat.c > +++ b/block/vvfat.c > @@ -868,7 +868,8 @@ static int init_directories(BDRVVVFATState* s, > { > direntry_t* entry=array_get_next(&(s->directory)); > entry->attributes=0x28; /* archive | volume label */ > - snprintf((char*)entry->name,11,"QEMU VVFAT"); > + snprintf((char*)entry->name,8,"QEMU VV"); > + snprintf((char*)entry->extension,3,"FAT"); > } > > /* Now build FAT, and write back information into directory */ > @@ -2256,7 +2257,7 @@ static int commit_one_file(BDRVVVFATState* s, > c = c1; > } > > - ftruncate(fd, size); > + assert(!ftruncate(fd, size)); Don't use expressions with side effects for assertions. If anyone compiles with NDEBUG defined, the ftruncate will be missing. Kevin