From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>
Subject: Re: [Qemu-devel] [PATCH 03/18] posix-aio-compat.c: fix warning with _FORTIFY_SOURCE
Date: Sun, 20 Dec 2009 23:02:56 +0000 [thread overview]
Message-ID: <200912202302.57060.paul@codesourcery.com> (raw)
In-Reply-To: <1261273167-3240-3-git-send-email-kirill@shutemov.name>
> --- a/posix-aio-compat.c
> +++ b/posix-aio-compat.c
> @@ -502,7 +502,8 @@ static void aio_signal_handler(int signum)
> if (posix_aio_state) {
> char byte = 0;
>
> - write(posix_aio_state->wfd, &byte, sizeof(byte));
> + if (write(posix_aio_state->wfd, &byte, sizeof(byte)) != sizeof(byte))
> + die("write()");
I'm pretty sure this change is wrong, and shows why you should never blindly
believe dumb analysis tools.
The write may fail harmlessly if the pipe is already full.
Paul
next prev parent reply other threads:[~2009-12-20 23:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 1:39 [Qemu-devel] [PATCH 01/18] Do not disable _FORTIFY_SOURCE Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 02/18] block.c: fix warning with _FORTIFY_SOURCE Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 03/18] posix-aio-compat.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 04/18] block/cow.c: fix warnings " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 05/18] block/qcow.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 06/18] block/vmdk.o: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 07/18] block/bochs.c: fix warning " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 08/18] block/vvfat.c: fix warnings " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 09/18] block/qcow2.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 10/18] net/slirp.c: fix warning " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 11/18] usb-linux.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 12/18] savevm.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 13/18] slirp/misc.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 14/18] vl.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 15/18] monitor.c: fix warnings " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 16/18] hw/pc.c: " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 17/18] path.c fix warning " Kirill A. Shutemov
2009-12-20 1:39 ` [Qemu-devel] [PATCH 18/18] linux-user/mmap.c: fix warnings " Kirill A. Shutemov
2009-12-22 20:49 ` [Qemu-devel] [PATCH 17/18] path.c fix warning " Blue Swirl
2009-12-22 20:43 ` [Qemu-devel] [PATCH 16/18] hw/pc.c: fix warnings " Blue Swirl
2009-12-22 21:12 ` [Qemu-devel] [PATCH 14/18] vl.c: fix warning " Blue Swirl
2009-12-22 19:21 ` [Qemu-devel] [PATCH 12/18] savevm.c: " Blue Swirl
2009-12-22 19:03 ` [Qemu-devel] [PATCH 11/18] usb-linux.c: " Blue Swirl
2009-12-22 18:50 ` [Qemu-devel] [PATCH 10/18] net/slirp.c: " Blue Swirl
2009-12-20 9:08 ` [Qemu-devel] Re: [PATCH 09/18] block/qcow2.c: fix warnings " Andreas Schwab
2009-12-20 10:48 ` [Qemu-devel] [PATCH 08/18] block/vvfat.c: " Kevin Wolf
2009-12-22 21:02 ` [Qemu-devel] [PATCH 07/18] block/bochs.c: fix warning " Blue Swirl
2009-12-20 23:02 ` Paul Brook [this message]
2009-12-22 18:35 ` [Qemu-devel] [PATCH 02/18] block.c: " Blue Swirl
2009-12-20 11:38 ` [Qemu-devel] [PATCH 01/18] Do not disable _FORTIFY_SOURCE Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912202302.57060.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=kirill@shutemov.name \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).