From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NMUnp-0000Wp-FN
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 18:03:05 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NMUnk-0000WN-Tz
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 18:03:05 -0500
Received: from [199.232.76.173] (port=60543 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NMUnk-0000WK-QC
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 18:03:00 -0500
Received: from mx20.gnu.org ([199.232.41.8]:60627)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1NMUnk-00055M-6x
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 18:03:00 -0500
Received: from mail.codesourcery.com ([38.113.113.100])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1NMUnj-0007Xs-BR
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 18:02:59 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 03/18] posix-aio-compat.c: fix warning with
	_FORTIFY_SOURCE
Date: Sun, 20 Dec 2009 23:02:56 +0000
References: <1261273167-3240-1-git-send-email-kirill@shutemov.name>
	<1261273167-3240-2-git-send-email-kirill@shutemov.name>
	<1261273167-3240-3-git-send-email-kirill@shutemov.name>
In-Reply-To: <1261273167-3240-3-git-send-email-kirill@shutemov.name>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <200912202302.57060.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>

> --- a/posix-aio-compat.c
> +++ b/posix-aio-compat.c
> @@ -502,7 +502,8 @@ static void aio_signal_handler(int signum)
>      if (posix_aio_state) {
>          char byte = 0;
> 
> -  write(posix_aio_state->wfd, &byte, sizeof(byte));
> +  if (write(posix_aio_state->wfd, &byte, sizeof(byte)) != sizeof(byte))
> +    die("write()");

I'm pretty sure this change is wrong, and shows why you should never blindly 
believe dumb analysis tools.

The write may fail harmlessly if the pipe is already full.

Paul