From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NMv5N-0004DC-Pr
	for qemu-devel@nongnu.org; Mon, 21 Dec 2009 22:06:57 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NMv5J-0004Ck-AE
	for qemu-devel@nongnu.org; Mon, 21 Dec 2009 22:06:57 -0500
Received: from [199.232.76.173] (port=56905 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NMv5J-0004Ch-6p
	for qemu-devel@nongnu.org; Mon, 21 Dec 2009 22:06:53 -0500
Received: from mx1.redhat.com ([209.132.183.28]:10012)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NMv5I-0001r7-9v
	for qemu-devel@nongnu.org; Mon, 21 Dec 2009 22:06:52 -0500
Date: Tue, 22 Dec 2009 01:06:35 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/7] QMP: Assure that returned data is a QDict
Message-ID: <20091222010635.0039e205@doriath>
In-Reply-To: <1261423279.2531.1333.camel@athens>
References: <1261149905-7622-1-git-send-email-lcapitulino@redhat.com>
	<1261149905-7622-4-git-send-email-lcapitulino@redhat.com>
	<1261423279.2531.1333.camel@athens>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nathan Baum <nathan@parenthephobia.org.uk>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Mon, 21 Dec 2009 19:21:18 +0000
Nathan Baum <nathan@parenthephobia.org.uk> wrote:

> On Fri, 2009-12-18 at 13:25 -0200, Luiz Capitulino wrote:
> > This is for debug purposes only.
> 
> This breaks quite a lot of commands where the returned data is a QList,
> e.g. query-commands, query-mice, query-cpus. Is the assert wrong, or are
> such commands meant to be returning a QDict?

 The assert is wrong, as we've defined that returning a QList of
QDicts is ok.

 We could check for a QList too and check its contents but I think that
only dropping the assert is ok for now.

 Will submit a patch and thanks for testing QMP.