From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NMv7h-00052u-NX for qemu-devel@nongnu.org; Mon, 21 Dec 2009 22:09:21 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NMv7d-00052B-Bw for qemu-devel@nongnu.org; Mon, 21 Dec 2009 22:09:21 -0500 Received: from [199.232.76.173] (port=56927 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NMv7d-000528-5B for qemu-devel@nongnu.org; Mon, 21 Dec 2009 22:09:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39704) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NMv7c-00028t-M4 for qemu-devel@nongnu.org; Mon, 21 Dec 2009 22:09:16 -0500 Date: Tue, 22 Dec 2009 01:09:06 -0200 From: Luiz Capitulino Message-ID: <20091222010906.4a42ab1d@doriath> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [STABLE 0.12] QMP: Drop wrong assert() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: nathan@parenthephobia.org.uk, aliguori@us.ibm.com Some commands return a QList of QDicts, which is valid, but will trig the assert(). Just drop it. Reported-by: Nathan Baum Signed-off-by: Luiz Capitulino --- monitor.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index c0dc48e..3af1d5c 100644 --- a/monitor.c +++ b/monitor.c @@ -283,7 +283,6 @@ static void monitor_protocol_emitter(Monitor *mon, QObject *data) if (!monitor_has_error(mon)) { /* success response */ if (data) { - assert(qobject_type(data) == QTYPE_QDICT); qobject_incref(data); qdict_put_obj(qmp, "return", data); } else { -- 1.6.6.rc3