From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NN930-00076u-OU for qemu-devel@nongnu.org; Tue, 22 Dec 2009 13:01:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NN92v-00075P-Mk for qemu-devel@nongnu.org; Tue, 22 Dec 2009 13:01:25 -0500 Received: from [199.232.76.173] (port=44443 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NN92v-00075J-9A for qemu-devel@nongnu.org; Tue, 22 Dec 2009 13:01:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45419) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NN92p-0003m8-TX for qemu-devel@nongnu.org; Tue, 22 Dec 2009 13:01:20 -0500 Date: Tue, 22 Dec 2009 23:29:53 +0530 From: Amit Shah Message-ID: <20091222175953.GA29251@amit-x200.redhat.com> References: <1261504146-26018-1-git-send-email-amit.shah@redhat.com> <1261504146-26018-2-git-send-email-amit.shah@redhat.com> <1261504146-26018-3-git-send-email-amit.shah@redhat.com> <4B310804.4090104@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B310804.4090104@suse.de> Subject: [Qemu-devel] Re: [PATCH 2/3] virtio-console: Add a virtio-serial bus, support for multiple devices and ports List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: armbru@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com On (Tue) Dec 22 2009 [18:55:16], Alexander Graf wrote: > Amit Shah wrote: > > This patch migrates virtio-console to the qdev infrastructure and > > creates a new virtio-serial bus on which multiple ports are exposed as > > devices. The bulk of the code now resides in a new file with > > virtio-console.c being just a simple qdev device. > > > > This interface enables spawning of multiple virtio consoles as well as generic > > serial ports. > > > > The older -virtconsole argument still works, but when using the new > > functionality, it is recommended to use > > > > -device virtio-serial-pci -device virtconsole,... > > > > The virtconsole device type accepts a chardev as an argument and a 'name' > > argument to identify the corresponding consoles on the host as well as the > > guest. The name, if given, is exposed via the 'name' sysfs attribute in the > > guest. > > > > Care has been taken to ensure compatibility with kernels that do not > > support multiple ports as well as accepting incoming migrations from older > > qemu versions. > > > > Signed-off-by: Amit Shah > > > > Please split this patch. I got dizzy after only reading 1/4th of it :-). Ah, sooner the better I guess. I'll do that soon. The interesting bits for you are in hw/s390-* and vl.c though. Amit